Conversation
Call server.init from runApp only after final ServerOptions are applied, and from JoobyExtension before start, so the service registry does not retain stale defaults from bootstrap. Fixes jooby-project#3995
Call server.init after test server options are finalized and before start for integration tests that no longer rely on Jooby constructor init.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4003 +/- ##
============================================
- Coverage 94.18% 94.16% -0.03%
+ Complexity 6655 6652 -3
============================================
Files 432 432
Lines 20893 20896 +3
Branches 2096 2096
============================================
- Hits 19679 19676 -3
- Misses 759 764 +5
- Partials 455 456 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.initfrom theJoobyconstructor during bootstrap (it ran beforerunAppapplied config-derivedServerOptions).server.initfor each app inrunAppafter final options are set, and inJoobyExtensionbeforestart.ServerOptionsmatch the configured instance after init.Fixes #3995
Test plan
mvn -pl jooby -am test -Dtest=Issue3995,JoobyRunnerTest,ServerTest(Java 21, Maven 3.8+)