Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four pages name types that are not in the code on
main:modules/metrics.adoc:MetricsDecoratorwas renamed toMetricsFilterin a371e6d (decorator: rename Route.Decorator to Route.Filter #2657). The sample under it readsuse(new MetricsModule()), butMetricsModuleis anExtensionandusetakes aRoute.Filter, so the sentence and both samples now useMetricsFilter.mvc-api.adoc:MvcExtensionwas removed in 0e01cf4 (remove: MvcFactory #3705).Jooby.mvctakesio.jooby.Extension.responses.adoc:Context.send(io.jooby.buffer.DataBuffer)was removed in b40f3ef. The overload issend(io.jooby.output.Output).value-api.adoc: the Value Factory sample implementsio.jooby.value.ValueConverter. There is no such interface.ValueFactory.puttakesio.jooby.value.Converter, which has theconvert(Type, Value, ConversionHint)method the sample overrides.Not touched:
migration/4.x.adocline 76 givesio.jooby.value.ValueConverteras the 4.x name, andmodules/graphql.adocstill has the "GraphQL Playground" section for the module removed in d97a058 (#3710).I have not built the docs.
Found with Striff, a tool I work on that checks documentation against code. The full report for this repository has the details.