Skip to content

[pull] master from Melon-Tropics:master - #162

Merged
pull[bot] merged 36 commits into
meonBot:masterfrom
Melon-Tropics:master
Mar 10, 2020
Merged

[pull] master from Melon-Tropics:master#162
pull[bot] merged 36 commits into
meonBot:masterfrom
Melon-Tropics:master

Conversation

@pull

@pull pull Bot commented Mar 10, 2020 •
edited
Loading

Copy link
Copy Markdown

See Commits and Changes for more details.

Created by pull[bot]. Want to support this open source service? Please star it : )

giltayar and others added 30 commits March 9, 2020 12:36
@giltayar @addaleax
doc: document self-referencing a package name
9dbe6ab 
Added a section for "Self-referencing a package using its name" that
documents importing a package's own exports (this was missed when
adding the feature).

PR-URL: nodejs#31680
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
@himself65 @addaleax
fs: fix valid id range on chown, lchown, fchown
0a539dd 
PR-URL: nodejs#31694
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@juanarbol @addaleax
src: create a getter for kernel version
c1e6725 
PR-URL: nodejs#31732
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@legendecas @addaleax
src: add missing namespace using statements in node_watchdog.h
e70705c 
Although these `using`s can derived from other header files, it will
be better to be self-contained.

PR-URL: nodejs#32117
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@lundibundi @addaleax
src: improve KVStore API
cee1452 
This adds `const char*` based APIs to KVStore to avoid multiple string
conversions (char -> Utf8 -> Local -> char etc.) when possible.

PR-URL: nodejs#31773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lundibundi @addaleax
src: simplify node_worker.cc using new KVStore API
98f4429 
PR-URL: nodejs#31773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@batrla @addaleax
test: allow EAI_FAIL in test-net-dns-error.js
077f9dc 
Test test-net-dns-error.js causes assertion failure on SunOS,
test expects ENOTFOUND, but OS returns EAI_FAIL.

Maximum length of a host name is 63 characters.
Test test-net-dns-error.js makes a connection attempt to
invalid host name (longer than maximum). Such
connection attempt on SunOS returns permanent failure
(EAI_FAIL) as invalid hostname won't be ever resolved.

PR-URL: nodejs#31780
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax
doc: link setRawMode() from signal docs
ef95de3 
Fixes: nodejs#32065

PR-URL: nodejs#32088
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@andred @addaleax
build: allow passing multiple libs to pkg_config
d3af527 
Sometimes it's necessary to pass multiple library names to pkg-config,
e.g. the brotli shared libraries can be pulled in with
    pkg-config libbrotlienc libbrotlidec

Update the code to handle both, strings (as used so far), and lists
of strings.

Signed-off-by: André Draszik <git@andred.net>

PR-URL: nodejs#32046
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@andred @addaleax
build: allow use of system-installed brotli
616b7fb 
brotli is available as a shared library since 2016, so it makes sense
to allow its use as a system-installed version.

Some of the infrastructure was in place already (node.gyp and
node.gypi), but some bits in the configure script here were missing.

Add them, keeping the default as before, to use the bundled version.

Refs: google/brotli#421
Signed-off-by: André Draszik <git@andred.net>

PR-URL: nodejs#32046
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@ProdipRoy89 @addaleax
test: changed function to arrow function
d5a06e7 
PR-URL: nodejs#32045
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@bnoordhuis @addaleax
test: use index.js if package.json "main" is empty
8ce6315 
Verify that the module loader uses index.js when the "main" property of
package.json is the empty string.

Refs: nodejs#32013

PR-URL: nodejs#32040
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@HarshithaKP @addaleax
src: handle NULL env scenario
e9fa5ae 
Convert hard assertion into a throw with a useful error
message in src/module_wrap.cc.

PR-URL: nodejs#31899
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR
test: increase test timeout to prevent flakiness
41ac192 
This increases the waiting time for each event from 500 to 750 ms.
The former timeout could be hit on very slow machines with high load.

PR-URL: nodejs#31716
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
doc: revise tools/icu/README.md
2a7d662 
* Simplify introductory sentence.
* Remove some passive voice.
* Make style in bulleted list a little more consistent.
* Remove superfluous list entry.

PR-URL: nodejs#32136
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Qard @mhdawson
async_hooks: add sync enterWith to ALS
d368dcc 
This allows transitioning the entire following sync and async execution
sub-tree to the given async storage context. With this one can be sure
the context binding will remain for any following sync activity and all
descending async execution whereas the `run*(...)` methods must wrap
everything that is intended to exist within the context. This is helpful
for scenarios such as prepending a `'connection'` event to an http
server which binds everything that occurs within each request to
the given context. This is helpful for APMs to minimize the need
for patching and especially adding closures.

PR-URL: nodejs#31945
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Gabriel Schulhof @legendecas
n-api: define release 6
c0c81ed 
Mark all N-APIs that have been added since version 5 as stable.

PR-URL: nodejs#32058
Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <legendecas@gmail.com>
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mmarchini
test: warn when inspector process crashes
9a78c82 
If the subprocess being inspected hard crashes, there will be no
information on the log, and the parent process will just wait until
timeout. Logging the error signal when it happens can help developers
understand failures faster.

Signed-off-by: Matheus Marchini <mmarchini@netflix.com>

PR-URL: nodejs#32133
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@andrewdotn @mmarchini
cli: allow --jitless V8 flag in NODE_OPTIONS
9e69d97 
This work is modeled on nodejs#30094 which allowed
`--disallow-code-generation-from-strings` in `NODE_OPTIONS`.

The `--jitless` v8 option has been supported since 12.0.0. As a v8
option, node automatically picks it up, but there have been a few issues
that were resolved by simply telling users about the option: nodejs#26758,

This PR:
  - allows `--jitless` in `NODE_OPTIONS`
  - documents `--jitless`
  - moves `--experimental-loader=module` to locally restore alphabetical
    order in option documentation

Refs: nodejs#30094
Refs: nodejs#26758
Refs: nodejs#28800

PR-URL: nodejs#32100
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
benchmark: refactor helper into a class
f64aafa 
This reverts commit 5b0308c.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR
benchmark: add test and all options and improve errors"
1760c23 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR
test: refactor all benchmark tests to use the new test option
9e40df7 
This reverts commit aa0a01b.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR
benchmark: remove special test entries
bb6125b 
This reverts commit 7cfbc9f.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@joyeecheung
src: make aliased_buffer.h self-contained
e0f5af3 
aliased_buffer.h uses MultiplyWithOverflowCheck() implemented
in util-inl.h

PR-URL: nodejs#31884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung
src: refactor debug category parsing
a8772da 
Move the debug category parsing into a new EnabledDebugList class,
so that it can be reused outside of Environment.

PR-URL: nodejs#31884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung
src: implement per-process native Debug() printer
51bc55f 
This patch adds a per-process native Debug() printer that can be
called when an Environment is not available.

PR-URL: nodejs#31884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung
tools: use per-process native Debug() printer in mkcodecache
192cb72 
PR-URL: nodejs#31884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
test: improve test-debug-usage
66e32ff 
test-debug-usage fails if run with `--trace-warnings` because the
regular expression checking does not allow for the resulting stack trace
from the deprecation warning.

The test also only tests two parts of the three-part usage message.

Improve the test so that it passes with `--trace-warnings` and verifies
all three parts of the usage message.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#32141
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
doc: remove personal pronoun usage in addons.md
36ce039 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
doc: remove personal pronoun usage in errors.md
c37c21b 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott and others added 6 commits March 9, 2020 19:47
@Trott
doc: remove personal pronoun usage in fs.md
fb36266 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
doc: remove personal pronoun usage in policy.md
73f2dbc 
Per our style guide, avoid personal pronouns (I, you, we, etc.) in
reference documentation.

PR-URL: nodejs#32142
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@sam-github @danbev
src: use C++ style for struct with initializers
811b3a9 
Fixes warning on clang 11:

        In file included from ../../src/node_http2.cc:6:
        ../../src/node_http2.h:508:15: warning: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Wnon-c-typedef-for-linkage]
        typedef struct {
                      ^
                       SessionJSFields
        ../../src/node_http2.h:512:33: note: type is not C-compatible due to this default member initializer
          uint32_t max_invalid_frames = 1000;
                                        ^~~~
        ../../src/node_http2.h:514:3: note: type is given name 'SessionJSFields' for linkage purposes by this typedef declaration
        } SessionJSFields;
          ^

PR-URL: nodejs#32134
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@rvagg
build: macOS package notarization
6db6af4 
Includes hardened-runtime patch from gdams from
nodejs#29216 (comment)

PR-URL: nodejs#31459
Refs: nodejs#29216
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Signed-off-by: Rod Vagg <rod@vagg.org>
@rvagg
deps: update term-size with signed version
d2f08a1 
PR-URL: nodejs#31459
Refs: nodejs#29216
Refs: sindresorhus/macos-terminal-size#3
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Signed-off-by: Rod Vagg <rod@vagg.org>
@rvagg
doc: official macOS builds now on 10.15 + Xcode 11
c933cbf 
PR-URL: nodejs#31459
Refs: nodejs#29216
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Signed-off-by: Rod Vagg <rod@vagg.org>
@pull pull Bot added the ⤵️ pull label Mar 10, 2020
@pull
pull Bot merged commit c933cbf into meonBot:master Mar 10, 2020
This was referenced Aug 19, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

⤵️ pull

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.