fix: make plugin option persistence configurable - #4241
Open
sb123sb123 wants to merge 1 commit into
Open
sb123sb123 wants to merge 1 commit into
sb123sb123 wants to merge 1 commit into
Conversation
Fixes micro-editor#4041 AI assistance: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4041
Issue: #4041
Problem
config.SetGlobalOptionis exposed to plugins throughSetGlobalOptionandSetGlobalOptionNative, but plugin changes no longer persist tosettings.jsonafter the plugin-write regression. Plugins can change the current session but cannot opt into the previous persistent behavior.Cause
The plugin wrappers hard-code
writeToFileto false, while command-driven option changes pass true. There is no user-configurable distinction between those two callers.Fix
Add the global
writesettingsoption. It defaults tosetto preserve command behavior;pluginsorset,pluginsenables persistence for plugin API changes, and an empty value disables both. The policy is applied centrally to string and native setters, and the option is documented.Tests
TestSetGlobalOptionPlugWritesSettingsWhenEnabled, covering the default session-only behavior and opt-in persistence to a temporarysettings.json.gofmt -l internal/action/command.go internal/action/command_test.go internal/config/settings.go(passed).git diff --check(passed).go test -count=1 ./internal/action ./internal/configandgo vet ./internal/action ./internal/configwere attempted.Limitations
The focused Go test and vet commands could not build because this host could not download the repository's required modules: connections to
https://proxy.golang.orgfailed with Windowsconnectexerrors.AI assistance
This pull request was prepared with assistance from OpenAI Codex. The author reviewed the changes, tests, and limitations before submission.