Affecting the ES6 library #47

Activity

1. mhegazy commented on Jan 13, 2016

   

   Mohamed Hegazy (mhegazy)

   on Jan 13, 2016

   Contributor

   More actions

   We should generate a new file dom.es6.d.ts, that include the definitions that contain es6-specific definitions. and we can wire it in the TS build in https://github.com/Microsoft/TypeScript/blob/master/Jakefile.js#L172
2. rapropos commented on Jan 13, 2016

   

   Robert Coie (rapropos)

   on Jan 13, 2016

   ContributorAuthor

   More actions

   If it's in a separate file, won't there be conflicting definitions in the eventual lib.es6.d.ts output? In this case, the method signature changes depending on the language level.
3. mhegazy commented on Jan 13, 2016

   

   Mohamed Hegazy (mhegazy)

   on Jan 13, 2016

   Contributor

   More actions

   if the difference is only in the return types, then we need to to have two separate files that include all definitions. then the build can pick one or the other based on the language version.
4. rapropos commented on Jan 13, 2016

   

   Robert Coie (rapropos)

   on Jan 13, 2016

   ContributorAuthor

   More actions

   Perhaps I'm not properly explaining what I'm worried about. As I understand things, when I add to overridingTypes.json, these changes are reflected both in lib.d.ts and lib.es6.d.ts via dom.generated.d.ts. Let's say we have:

       {
            "kind": "method",
            "interface": "Foo",
            "name": "bar",
            "signatures": ["bar(param:string): PromiseLike<string>"]
        }
   

   So if there is a new file, say overridingTypesEs6.json, and I put the following version in it:

       {
            "kind": "method",
            "interface": "Foo",
            "name": "bar",
            "signatures": ["bar(param:string): Promise<string>"]
        }
   

   ...and that gets put into a dom.es6.d.ts file, won't both versions of the declaration try to end up in lib.es6.d.ts? The first version via the existing mechanism, and the second via the proposed new route?

   Perhaps there could be an es6-signatures key that would provide method signatures to be picked up in lieu of the ones specified in signatures?
5. mhegazy commented on Jan 14, 2016

   

   Mohamed Hegazy (mhegazy)

   on Jan 14, 2016

   Contributor

   More actions

   what i meant is to generate two files here, dom.generated.d.ts and dom.es6.generated.d.ts. the second can be just an augmentation to the first, or it can be a replica of it with only different return types. then in the main ts repo, we would wire the build to pick one or the other based on which lib it is building.
6. saschanaz commented on Mar 27, 2017

   

   Kagami Sascha Rosylight (saschanaz)

   on Mar 27, 2017

   Contributor

   More actions

   Is this fixed by microsoft/TypeScript#14053?
7. mhegazy commented on Mar 27, 2017

   

   Mohamed Hegazy (mhegazy)

   on Mar 27, 2017

   Contributor

   More actions

   Yes. we should just use Promise everywhere now.
8. Mohamed Hegazy (mhegazy)

   closed this as completedon Mar 27, 2017
9. Nathan Shively-Sanders (sandersn)

   added a commit that references this issue on Jun 12, 2020

   Change SubtleCrypto method return types to Promise (#843)

   ...

   8133ef6