Skip to content

Important changes for 4.2 #960

Description

@orta
  const dateOptions = {
     weekday: "long",
     year: "numeric",
     month: "long",
     day: "numeric",
   };

   const date = new Date().toLocaleString("en-US", dateOptions);

would now need to be

   const date = new Date().toLocaleString("en-US", {
     weekday: "long",
     year: "numeric",
     month: "long",
     day: "numeric",
   });

Or to use as const

Activity

  1. HolgerJeromin commented on Dec 13, 2020

    @HolgerJeromin
    Contributor

    Can/should we update the typing of querySelector, querySelectorAll and closest, too?

    Ref #885 (comment)

  2. orta commented on Dec 21, 2020

    @orta
    ContributorAuthor

    It was, I used this issue to keep track of breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions