Repository navigation
String templates not colorized in VS 2013 #1698
Description
Activity
- addedBugA bug in TypeScriptA bug in TypeScriptVisual StudioIntegration with Visual StudioIntegration with Visual Studio
on Jan 16, 2015 - addedBy DesignDeprecated - use "Working as Intended" or "Design Limitation" insteadDeprecated - use "Working as Intended" or "Design Limitation" insteadDuplicateAn existing issue was already createdAn existing issue was already created
on Jan 16, 2015 DanielRosenwasser commented
on Jan 16, 2015 MemberMore actionsDuplicate of #1477, see my comment for an explanation of the technical difficulties associated with this: #1477 (comment) .
Though, we could enhance the lexical classifier, but I don't know if it's really worth it.
- addedDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptThe issue relates to the different libraries shipped with TypeScriptWon't FixThe severity and priority of this issue do not warrant the time or complexity needed to fix itThe severity and priority of this issue do not warrant the time or complexity needed to fix itToo ComplexAn issue which adding support for may be too complex for the value it addsAn issue which adding support for may be too complex for the value it addsand removedBy DesignDeprecated - use "Working as Intended" or "Design Limitation" insteadDeprecated - use "Working as Intended" or "Design Limitation" insteadDomain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptThe issue relates to the different libraries shipped with TypeScript
on Jan 16, 2015 - removed this from the TypeScript 1.5 milestone
on Jan 18, 2015 Daniel Rosenwasser (@DanielRosenwasser), colour would really help
The template string version is more difficult to comprehend.
DanielRosenwasser commented
on Jan 20, 2015 MemberMore actionsNoel Abrahams (@NoelAbrahams) I understand that. This is probably a lousy experience for most people, and as the one who implemented templates, I personally felt like I owed our users something a little better. This afternoon I whipped something up.
I have a branch from which you can build the source code and swap out your language service in VS2013. The specific commit (e42ce9c) can be cherry picked onto the
release-1.4branch.Basically, as long as your template strings' substitutions don't contain:
- Expressions with closing curly braces on a separate line
- Other substitution template strings that span multiple lines
this should fit your needs.
If it doesn't, well, you probably have other problems to worry about. 😉
Daniel Rosenwasser (@DanielRosenwasser), will try that out. Do you mean to say that in VS 2015 this should be coloured correctly? (A bug in NTVS is preventing us from using VS 2015 atm, but we should be migrating soon.)
Thanks!
DanielRosenwasser commented
on Jan 20, 2015 MemberMore actionsYou're very welcome! Let me know how this works out for you. Yes, 2015 should already work with template colorization.
That's unfortunate - does the Node Tools team know about the bug?
Yes, there's a discussion item.
- addedFixedA PR has been merged for this issueA PR has been merged for this issueand removedWon't FixThe severity and priority of this issue do not warrant the time or complexity needed to fix itThe severity and priority of this issue do not warrant the time or complexity needed to fix it
on Feb 13, 2015 DanielRosenwasser commented
on Feb 13, 2015 MemberMore actionsA fix is now in
masterthrough #2026.- removedToo ComplexAn issue which adding support for may be too complex for the value it addsAn issue which adding support for may be too complex for the value it adds
on Feb 13, 2015 - locked and limited conversation to collaborators
on Jun 18, 2018

String templates should be colorizes like string literals.