Skip to content

String templates not colorized in VS 2013 #1698

Description

String templates should be colorizes like string literals.

Activity

  1. DanielRosenwasser commented on Jan 16, 2015

    @DanielRosenwasser
    Member

    Duplicate of #1477, see my comment for an explanation of the technical difficulties associated with this: #1477 (comment) .

    Though, we could enhance the lexical classifier, but I don't know if it's really worth it.

  2. added
    Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScript
    Won't FixThe severity and priority of this issue do not warrant the time or complexity needed to fix it
    Too ComplexAn issue which adding support for may be too complex for the value it adds
    and removed
    By DesignDeprecated - use "Working as Intended" or "Design Limitation" instead
    Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScript
    on Jan 16, 2015
  3. NoelAbrahams commented on Jan 19, 2015

    @NoelAbrahams

    Daniel Rosenwasser (@DanielRosenwasser), colour would really help

    image

    The template string version is more difficult to comprehend.

  4. DanielRosenwasser commented on Jan 20, 2015

    @DanielRosenwasser
    Member

    Noel Abrahams (@NoelAbrahams) I understand that. This is probably a lousy experience for most people, and as the one who implemented templates, I personally felt like I owed our users something a little better. This afternoon I whipped something up.

    I have a branch from which you can build the source code and swap out your language service in VS2013. The specific commit (e42ce9c) can be cherry picked onto the release-1.4 branch.

    Basically, as long as your template strings' substitutions don't contain:

    • Expressions with closing curly braces on a separate line
    • Other substitution template strings that span multiple lines

    this should fit your needs.

    If it doesn't, well, you probably have other problems to worry about. 😉

  5. NoelAbrahams commented on Jan 20, 2015

    @NoelAbrahams

    Daniel Rosenwasser (@DanielRosenwasser), will try that out. Do you mean to say that in VS 2015 this should be coloured correctly? (A bug in NTVS is preventing us from using VS 2015 atm, but we should be migrating soon.)

    Thanks!

  6. DanielRosenwasser commented on Jan 20, 2015

    @DanielRosenwasser
    Member

    You're very welcome! Let me know how this works out for you. Yes, 2015 should already work with template colorization.

    That's unfortunate - does the Node Tools team know about the bug?

  7. NoelAbrahams commented on Jan 21, 2015

    @NoelAbrahams

    Yes, there's a discussion item.

  8. added
    FixedA PR has been merged for this issue
    and removed
    Won't FixThe severity and priority of this issue do not warrant the time or complexity needed to fix it
    on Feb 13, 2015
  9. DanielRosenwasser commented on Feb 13, 2015

    @DanielRosenwasser
    Member

    A fix is now in master through #2026.

  10. locked and limited conversation to collaborators on Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugA bug in TypeScriptDuplicateAn existing issue was already createdFixedA PR has been merged for this issueVisual StudioIntegration with Visual Studio

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions