Repository navigation
Typescript ignores typings when using tsconfig.json paths #17583
Description
TypeScript Version: 2.3.4, 2.4.2, 2.5.0-dev.20170801
fabric@1.7.17 and @types/fabric are installed.
Code
tsconfig.json
{
"compilerOptions": {
"target": "es5",
"module": "commonjs",
"baseUrl": "src/",
"sourceMap": true,
"outDir": "dist/out-tsc",
"paths": {
"fabric": [ "../node_modules/fabric/dist/fabric.require.js" ]
}
},
"exclude": [
"node_modules"
],
"compileOnSave": false
}src/app.ts
import * as fabric from "fabric";
window.addEventListener("load", function () {
const canvas = new fabric.Canvas("my-canvas");
// create a rectangle object
var rect = new fabric.Rect({
left: 100,
top: 100,
fill: "red",
width: 20,
height: 20,
lockUniScaling: true
});
// "add" rectangle onto canvas
canvas.add(rect);
// canvas.toSVG() is faulty inside definitions
console.log(canvas.toSVG());
});Expected behavior:
TSC should report an error that toSVG needs parameters.
Actual behavior:
typescript doesn't load any type definitions for the fabric module.
Activity
DanielRosenwasser commentedon Aug 3, 2017
If you have
.d.tsfiles available, why are you re-mapping to the.jsfile which has no type information associated with it? That's why it's not working the way you expect.In fact, why are you even using
pathsif you have the@typespackage available? When targetingcommonjs(or usingnodejsfor yourmoduleResolutionstrategy) the.d.tsfiles should automatically get picked up.WoMayr commentedon Aug 3, 2017
I do understand. The problem is, that I am using it in the context of an angular4 project using angular-cli. Angular-CLI does not support aliasing or at least only using the information from
paths(See angular/angular-cli#6282).But to use fabric.js with
importI need to use a different file than the one stated in thepackage.jsonsmainfield or the typings from@types/fabricwon't fit. My hope was that withpathsI can target the correct JavaScript file and I expected it to leave the connection to the typings intact as it was even suggested from the angular-cli team.I somehow thought that it might be a bug with tsc but thinking at it again:
pathsonly tells tsc where to look for the typings at it does not alter the imports itself. So no wonder it doesn't work as I expected it.Is there a way to use
pathsand still have the type information available or at least attach it manually? I tried adding../node_modules/@types/fabricto thefabricentry inpathsbut that didn't work (desperate attempt).mhegazy commentedon Aug 17, 2017
Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.