Skip to content

typeof React.Component stopped working #18946

Closed
Closed
typeof React.Component stopped working#18946
Labels
Working as IntendedThe behavior described is the intended behavior; this is not a bug

Description

@mikew
Mike Wyatt (mikew)
opened on Oct 4, 2017

TypeScript Version: 2.5.3

Code

class MyComponent extends React.Component<{}, {}> {
  render () {
    return null
  }
}

function thisTakesAComponent (component: typeof React.Component) {

}

thisTakesAComponent(MyComponent)

Expected behavior:
Should compile fine.

Actual behavior:

Argument of type 'typeof MyComponent' is not assignable to parameter of type 'typeof Component'.
  Type 'MyComponent' is not assignable to type 'Component<P, S>'.
    Types of property 'setState' are incompatible.
      Type '{ <K extends never>(f: (prevState: {}, props: {}) => Pick<{}, K>, callback?: (() => any) | undefi...' is not assignable to type '{ <K extends keyof S>(f: (prevState: S, props: P) => Pick<S, K>, callback?: (() => any) | undefin...'.
        Types of parameters 'f' and 'f' are incompatible.
          Types of parameters 'prevState' and 'prevState' are incompatible.
            Type '{}' is not assignable to type 'S'.

Activity

  2. mikew commented on Oct 4, 2017

    @mikew
    Mike Wyatt (mikew)
    on Oct 4, 2017
    Author

    And what about for stateless functions? IE I don't want "a type of subclasses of React.Component", I want "something that will be rendered correctly with React.createElement".

  4. mhegazy commented on Oct 4, 2017

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Oct 4, 2017
    Contributor

    why not:

     function thisTakesAComponent <P>(component: React.SFC<P> | React.ComponentClass<P>) {
 }
  5. Mohamed Hegazy (mhegazy)
    added
    Working as IntendedThe behavior described is the intended behavior; this is not a bug
    on Oct 4, 2017

  6. mhegazy commented on Oct 19, 2017

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Oct 19, 2017
    Contributor

    Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

  7. Mohamed Hegazy (mhegazy)
    closed this as completedon Oct 19, 2017

  8. samuelneff commented on Mar 11, 2018

    @samuelneff
    Samuel Neff (samuelneff)
    on Mar 11, 2018

    Not sure if this was applicable when originally asked, but now you can do this:

        function thisTakesAComponent(component: ReactType) {
    }
  9. microsoft
    locked and limited conversation to collaborators on Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Working as IntendedThe behavior described is the intended behavior; this is not a bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions