Preference for including file extension on auto imports #24779

Activity

1. Matt Bierner (mjbvz)

   added

   VS Code TrackedThere is a VS Code equivalent to this issueThere is a VS Code equivalent to this issue

   on Jun 7, 2018
2. Mohamed Hegazy (mhegazy)

   added

   SuggestionAn idea for TypeScriptAn idea for TypeScript

   on Jun 8, 2018
3. mhegazy commented on Jun 8, 2018

   

   Mohamed Hegazy (mhegazy)

   on Jun 8, 2018

   Contributor

   More actions

   PRs welcomed for adding support of file extension preference
4. Mohamed Hegazy (mhegazy)

   added this to the Community milestone on Jun 8, 2018
5. Mohamed Hegazy (mhegazy)

   added

   Help WantedYou can do thisYou can do this

   on Jun 8, 2018
6. Ryan Cavanaugh (RyanCavanaugh)

   modified the milestones: Community, Backlog on Mar 7, 2019
7. Matt Bierner (mjbvz)

   added

   VS Code PriorityCritical issues that VS Code needs fixed in the current TypeScript milestoneCritical issues that VS Code needs fixed in the current TypeScript milestone

   on Jan 29, 2020
8. Matt Bierner (mjbvz)

   assigned

   Andrew Branch (andrewbranch)

   on Feb 5, 2020
9. Matt Bierner (mjbvz)

   modified the milestones: Backlog, TypeScript 3.9.0 on Feb 5, 2020
10. Matt Bierner (mjbvz)

    added

    CommittedThe team has roadmapped this issueThe team has roadmapped this issue

    and removed

    Help WantedYou can do thisYou can do this

    on Feb 5, 2020
11. andrewbranch commented on Feb 10, 2020

    

    Andrew Branch (andrewbranch)

    on Feb 10, 2020

    Last edited by andrewbranch

    Member

    More actions

    This has actually existed in TS since #26177, but was never added to typescript-language-features. I just tried it and confirmed it works. From conversation in #28288, though, it sounds like we should maybe consider setting .js endings as the default for JS projects? Matt Bierner (@mjbvz) Daniel Rosenwasser (@DanielRosenwasser) thoughts? (Edit: Actually, I think this would still be a surprising default for most JS users—I don’t think it’s common in Node, and most frontend users still use a bundler.)
12. Andrew Branch (andrewbranch)

    added

    Fix AvailableA PR has been opened for this issueA PR has been opened for this issue

    and removed

    Fix AvailableA PR has been opened for this issueA PR has been opened for this issue

    on Feb 10, 2020
13. Andrew Branch (andrewbranch)

    added

    Fix AvailableA PR has been opened for this issueA PR has been opened for this issue

    on Feb 19, 2020
14. Andrew Branch (andrewbranch)

    closed this as completedin #36725on Feb 20, 2020
15. wsmd commented on May 6, 2020

    

    Waseem Dahman (wsmd)

    on May 6, 2020

    Last edited by wsmd

    More actions

    Question related to microsoft/vscode#90405 - Is there an existing configuration that can achieve the same behavior for autosuggest when typing the import statement manually?

    For example:

    {
      "javascript.preferences.importModuleSpecifierEnding": "js",
    }

    import { someFunction } from './|';
                                    ^ when picking a file from suggestions here,
                                      the file extension seems to always be omitted
16. andrewbranch commented on May 6, 2020

    

    Andrew Branch (andrewbranch)

    on May 6, 2020

    Member

    More actions

    I can’t immediately think of a reason why we shouldn’t respect that same setting for module specifier completions. Waseem Dahman (@wsmd) would you mind opening a new bug for this?
17. wsmd commented on May 6, 2020

    

    Waseem Dahman (wsmd)

    on May 6, 2020

    Last edited by wsmd

    More actions

    Thanks Andrew Branch (@andrewbranch)! Will do! I think it would be nice to have importModuleSpecifierEnding applies for both auto-imports and manual import suggestions 👍

    Reported here https://github.com/microsoft/vscode/issues/97106