Skip to content

Show exact error position in arrays & arrow functions #27030

Closed
Closed
Show exact error position in arrays & arrow functions#27030
Assignees
weswigham
Labels
Domain: Error MessagesThe issue relates to error messagingExperience EnhancementNoncontroversial enhancementsFixedA PR has been merged for this issue
Milestone
TypeScript 3.2

Description

@cevek
cevek
opened on Sep 11, 2018

If it is not assignable error and infered expression type origin comes from inside of ast error boundaries we can show exact position of an error source

interface Foo {
    a: number;
}

function foo1(): () => Foo {
    return () => ({a: ''});
}

function foo2(): Promise<Foo> {
    return Promise.resolve({a: ''});
}

function foo3(): Foo[] {
    return [{a: ''}];
}
var y: Foo[] = [{a: ''}] 
var z: Foo[] = [].map(() => ({a: ''}))

agdagag

Daniel Rosenwasser (@DanielRosenwasser) what do you think?

Activity

  1. Daniel Rosenwasser (DanielRosenwasser)
    added
    Domain: Error MessagesThe issue relates to error messaging
    Experience EnhancementNoncontroversial enhancements
    on Sep 11, 2018
  2. Daniel Rosenwasser (DanielRosenwasser)
    assigned
    Wesley Wigham (weswigham)
    on Sep 11, 2018
  3. Daniel Rosenwasser (DanielRosenwasser)
    added this to the TypeScript 3.2 milestone on Sep 11, 2018

  4. DanielRosenwasser commented on Sep 11, 2018

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Sep 11, 2018
    Member

    This can get arbitrarily complex, but I think that for certain arrays and arrow functions, we can definitely do better here.

  5. DanielRosenwasser commented on Sep 11, 2018

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Sep 11, 2018
    Member

    Specifically I can see us dealing with foo1, foo3, and y pretty easily. I think that foo2 and z will be harder.

  6. weswigham commented on Sep 11, 2018

    @weswigham
    Wesley Wigham (weswigham)
    on Sep 11, 2018
    Member

    Daniel Rosenwasser (@DanielRosenwasser) It should just be a matter of adding more cases to elaborateError to handle diving into more expressions.

  7. Daniel Rosenwasser (DanielRosenwasser)
    changed the title [-]Error output: show exact error position if it possible [/-] [+]Show exact error position in arrays & arrow functions[/+] on Sep 11, 2018
  8. Daniel Rosenwasser (DanielRosenwasser)
    modified the milestones: TypeScript 3.2, TypeScript 3.1 on Sep 11, 2018
  9. Ryan Cavanaugh (RyanCavanaugh)
    modified the milestones: TypeScript 3.1, TypeScript 3.2 on Sep 24, 2018
  10. Daniel Rosenwasser (DanielRosenwasser)
    added
    FixedA PR has been merged for this issue
    on Oct 30, 2018

  11. DanielRosenwasser commented on Oct 30, 2018

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Oct 30, 2018
    Member

    I think that the majority of work done has been done here; the Promise.resolve case is a little harder, but if it's compelling enough for your day-to-day coding I encourage you to open up another issue. Thanks cevek!

  12. Daniel Rosenwasser (DanielRosenwasser)
    closed this as completedon Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Domain: Error MessagesThe issue relates to error messagingExperience EnhancementNoncontroversial enhancementsFixedA PR has been merged for this issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions