Repository navigation
Different types based on visibility #43553
Copy link
Copy link
Open
Labels
Awaiting More FeedbackThis means we'd like to hear from more people who would be helped by this featureThis means we'd like to hear from more people who would be helped by this featureSuggestionAn idea for TypeScriptAn idea for TypeScript
Description
Suggestion
🔍 Search Terms
- Different types based on visibility
- Different types based on private, protected properties
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
⭐ Suggestion
Make properties (and getters/setters) be able to have different types based on where they are accessed from (AKA visibility).
It should have the following rules:
- The least visible (relative from where it's being accessed) type should be used when accessing/setting the property (
privateoverprotectedoverpublic). - This should only be a type difference and not change the actual js value that is returned.
- Only the least visible type can be writable.
- The more visible types need to at least include the least visible type.
- Properties can only be initialized on their least visible version
- Types need to be ordered from most visible to least visible
class Foo {
public readonly prop1: ReadonlyArray<unknown>;
private readonly prop1: unknown[] = [];
// Implicitly also means:
// protected readonly prop1: ReadonlyArray<unknown>;
public readonly prop2: number;
protected prop2: number;
// Implicitly also means:
// private prop2: number;
// Error: Only the least visible type can be writeable
protected prop3: number | string;
private prop3: number;
// Error: More visible types need to include the least visible type
protected readonly prop4: string;
private prop4: number;
// Error: Property types need to be ordered from most to least visible
private readonly prop5: unknown[] = [];
public readonly prop5: ReadonlyArray<unknown>;
// Error: Properties can only be initialized on their least visible type
public readonly prop6: ReadonlyArray<unknown> = [];
private readonly prop6: unknown[];
fooMethod() {
// Works
this.prop1.push(1);
// Works
this.prop2 = 2;
}
}
class FooBar extends Foo {
fooBarMethod() {
// Works
const length = this.prop2.length;
// Error: Property 'push' does not exist on type 'readonly unknown[]'
this.prop1.push(1);
// Works
this.prop2 = 2;
}
}
const foo = new Foo();
// Works
const length = foo.prop2.length;
// Error: Property 'push' does not exist on type 'readonly unknown[]'
foo.prop1.push(1);
// Works
const prop2Value = foo.prop2;
// Error: Cannot assign to 'prop2' because it is a read-only property.
foo.prop2 = 2;📃 Motivating Example
It removes the need of using custom public/protected getters back by protected/private properties reducing a lot of clutter and repetitive "dumb" code when implementing a strictly typed API.
💻 Use Cases
What do you want to use this for?
Class APIs where you can see the inner state but may only mutate it through the provided method calls.
What workarounds are you using in the meantime?
Getters backed by properties prefixed with _.
class Foo {
private _prop: number;
get prop(): number {
return this._prop;
}
}
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Awaiting More FeedbackThis means we'd like to hear from more people who would be helped by this featureThis means we'd like to hear from more people who would be helped by this featureSuggestionAn idea for TypeScriptAn idea for TypeScript
Activity
MartinJohns commentedon Apr 6, 2021
It sounds like you want #37487.
Otherwise this proposal strikes me as really odd. How would this behave?
Jet132 commentedon Apr 6, 2021
Not only do I want to make some properties be readonly when accessed publicly but I also want them to change their type. For example from
ArraytoReadonlyArrayor fromMaptoReadonlyMap. There will most likely need to be restrictions on how different those types can be. Like the more visible types need to be more open than the least visible type and only the least visible type can be writeable.Though those might sound like quite strict rules they are applicable to most common use cases (at least for me) where you want to secure the mutability of a property.
paul-marechal commentedon Apr 6, 2021
Codec (@Jet132) For sure such constraints will have to be met.
Martin Johns (@MartinJohns) the example you wrote should result in an error because
stringis not compatible withnumber. Like the type'abc'is compatible withstring, butstringis not compatible with'abc'. The same constraints should be respected where more closed declarations must be compatible with more opened ones.paul-marechal commentedon Apr 6, 2021
Although thinking about it more, there is something odd, see:
In such a case, the public member can be assigned any string, violating the private
'abc'constraint. Does that mean that both types have to either be the same to bemutablesettable, and if different more open declarations must be readonly?Jet132 commentedon Apr 6, 2021
If you look at my first comment I actually suggested only having the least visible type be mutable. I'll change the issue proposal to fit it
paul-marechal commentedon Apr 6, 2021
I had missed it, good to mention it in the proposal.
Another question is where would initialization be done? Only on the least visible type? Should the declaration order matter?
Jet132 commentedon Apr 6, 2021
The initialization should be done in the least visible type and about the declaration order, I'm not sure but it should matter for readability. We can think of the more visible types like function overloads just for visibility. Would it then make sense to order it from most to least visible to have the initialization at the bottom?
paul-marechal commentedon Apr 6, 2021
Sounds good to me at least. Like you said it would be similar to functions overloads.
Lastly, what would it mean to declare all 3 scopes?
MartinJohns commentedon Apr 6, 2021
TypeScript has no way to declare types as mutable / immutable. This would require something like #17181.
robbiespeed commentedon Apr 6, 2021
If the ergonomics were improved for the cases where the value type doesn't change between access levels, then I would prefer this proposal over #37487. One suggestion, is if the value type was implicit for following declarations of the same property.
Codec (@Jet132) rather than requiring that only least visible is mutable which would really limit the usefulness of this proposal, what if types were constrained at mutation to use a intersection of all types across access levels.
This would be helpful in handling non primitives as well.
This eliminates the risk that prop could be replaced with a less capable object which would cause errors when a
Boxattempts to use thesetmethod inside theFooclass.paul-marechal commentedon Apr 6, 2021
Martin Johns (@MartinJohns) I think we used the wrong terminology, we meant changing the value of the property. By "non-mutable" what we meant was "non-settable" as in prefixing with
readonly.paul-marechal commentedon Apr 6, 2021
Robbie Speed (@robbiespeed) this means leaking implementation details and breaking encapsulation? I am not in favor of this. Whenever you want to change implementation details, what is effectively used publicly might break.
Although I'd be fine with the type inference.
Jet132 commentedon Apr 6, 2021
This would just make every scope have a different type. Note that the example above would throw an error because of the inclusive rule.
It would need to be at least the following:
Robbie Speed (@robbiespeed) I agree with @marechal-p. The type should be explicitly set. It also prevents confusion of why public
propsuddenly has the type'abc'notstringas explicitly specified.The second example doesn't make much sense as you are restricting the consumer of the class from modifying an object which it already has the modifyable instance of. What use would it be to restrict the user from modifying it via the property?
btw. In you example, it would make the
box.valueproperty readonly but expose thebox.set()method completely negating the readonly part of it.There are no real usecases I can think of where this behavior would actually be needed. As I've mentioned in my first comment the rules do seem quite strict but in practice (at least in mine and those I can imagine) you won't be needing the features for anything more.
Edit: and I'm also fine with type inference 👍
Jet132 commentedon Apr 6, 2021
I've updated the proposal but without the type inference. There I'm not sure if it wouldn't be better to have the inference from bottom to top as you can only initialize it on the bottom.
This would make type inference even more useful though I'm not sure if typescript has an unwritten rule that type inference needs to be done from top-left to bottom-right.
ExE-Boss commentedon Apr 6, 2021
Codec (@Jet132)
Note that you need to use the
declaremodifier, since:compiles to:
whereas:
compiles to:
Jet132 commentedon Apr 6, 2021
Well, the optimal implementation would not require the
declare. Just like function overloads don't require it.robbiespeed commentedon Apr 7, 2021
I think it would be best if order wasn't enforced, or instead of going from most to least visible it went from least to most. It seems clearer to me when initialization and/or type definition can come first.
Jet132 commentedon Apr 7, 2021
hmm tbh, I would rather keep the order from most to least visible. It's more consistent with function overloads and also gives a visual indication of how the feature works. Like any not specified visibility just implicitly inherits that from the above (if there is one).
Maybe we should consider leaving out the type-inference to be even more consistent with function overloads and also with typescript's tendency to infer from left to right, top to bottom.
Fasteroid commentedon Nov 14, 2024
Hate to necro this, but I'd really love to see this too. I'm running into Jet's exact problem with "dumb" getter/setters that shouldn't have to exist. Any plans for this yet?
denis-migdal commentedon Jul 6, 2025
+1 this would indeed be a quite useful feature.
denis-migdal commentedon Mar 3, 2026
I discussed a similar feature here, going a little more in depth into the technical aspect and behavior.
Other workarounds:
Workaround 1: use an identity function.
However, this is kind of fragile if the attribute is redefined in the subclasses.
Depending on the case, we can use a
asMutable()function (removesreadonly), or aasRW():Workaround 2:
Add an
internalinterface:This requires to declare interfaces (not a bad thing in itself).
This makes subclassing a little more difficult as we have to remove the internal properties before exposing the new class.
However, when using helpers using internal features, e.g. :
This might cause issues as we could give a class implementing
Foo, but notInternalFoo.Making
FooandInternalFooas abstract classes, with an abstract property inFoo, only defined inInternalFoocould work, but this starts to be quite hacky.denis-migdal commentedon Mar 5, 2026
Workaround 3: use an
internalsproperty