Activity

1. sandersn commented on Oct 21, 2021

   

   Nathan Shively-Sanders (sandersn)

   on Oct 21, 2021

   Member

   More actions

   The excessive stack depth in FindConditions is from a structural comparison of a class to an empty subclass. I'll bisect it to find out what caused it. Possibly related to #45672?
2. sandersn commented on Oct 21, 2021

   

   Nathan Shively-Sanders (sandersn)

   on Oct 21, 2021

   Member

   More actions

   The excessive stack depth in react-hook-form happens during type parameter inference, but that's all I know right now.

   👀React with 👀1Reacted by Andrew Branch
3. sandersn commented on Oct 22, 2021

   

   Nathan Shively-Sanders (sandersn)

   on Oct 22, 2021

   Member

   More actions

   It is fixed by #46429.

   🎉React with 🎉1Reacted by Andrew Branch
4. sandersn commented on Oct 22, 2021

   

   Nathan Shively-Sanders (sandersn)

   on Oct 22, 2021

   Member

   More actions

   Here's a standalone repro for FindConditions's excessive stack depth error. I'm going to bisect to find out when it started failing.

   class FindOperator<T> { }
   type FindConditions<T> = {
       [P in keyof T]?: FindConditions<T[P]> | FindOperator<FindConditions<T[P]>>;
   };
   declare class Repository<Entity extends {[key: string]: any;}> {
       update(criteria: object|FindConditions<Entity>): void
   }
   class MR<Entity> extends Repository<Entity> {
   }
   
   export function repro(): any {
     const x: Repository<any> = new MR()
     return x
   }
5. andrewbranch commented on Oct 22, 2021

   

   Andrew Branch (andrewbranch)

   on Oct 22, 2021

   Member

   More actions

   On the Cannot find module './App.svelte' or its corresponding type declarations. ones, I’m not sure how this would have been working before; we don’t resolve non-JS/TS file extensions in tsc.

   5 of 17 projects failed to build with the old tsc

   Oh wait, what does this mean? Are these errors not new? Andrew Casey (@amcasey)
6. amcasey commented on Oct 22, 2021

   

   Andrew Casey (amcasey)

   on Oct 22, 2021

   Last edited by amcasey

   Member

   More actions

   That means that 5 of 17 projects were considered not to have valid baselines and new errors from those projects were not reported.

   In general, only errors in projects that built cleanly with the baseline compiler are reported in these bugs.

   👍React with 👍1Reacted by Andrew Branch
7. sandersn commented on Oct 22, 2021

   

   Nathan Shively-Sanders (sandersn)

   on Oct 22, 2021

   Member

   More actions

   FindCondition's excessive stack depth error is from #41821, which is not too surprising, we must have been hitting Maybe before.
8. sandersn commented on Oct 25, 2021

   

   Nathan Shively-Sanders (sandersn)

   on Oct 25, 2021

   Last edited by sandersn

   Member

   More actions

   The two xstate examples don't repro locally, which is not surprising.
   Edit: The two errors in xstate packages also don't repro, which is surprising.

   👀React with 👀1Reacted by Andrew Branch
9. Andrew Branch (andrewbranch)

   closed this as completedon Nov 1, 2021
10. microsoft

    locked as resolved and limited conversation to collaborators on Oct 21, 2025