Skip to content

getDocumentHighlights does not return uses of SFCs in JSX elements #7109

Closed
Closed
getDocumentHighlights does not return uses of SFCs in JSX elements#7109
Assignees
RyanCavanaugh
Labels
BugA bug in TypeScriptDomain: JSX/TSXRelates to the JSX parser and emitterFixedA PR has been merged for this issue
Milestone
TypeScript 2.0

Description

@myitcv
Paul Jolly (myitcv)
opened on Feb 17, 2016

This issue first surfaced in palantir/tslint#972

I think the following is a minimal reproduction of the problem:

/// <reference path='fourslash.ts' />

//@Filename: file.tsx
//// export function BuildMyComponent(): JSX.Element {
////    let [|StringComponentA|]: React.ComponentClass<{}>;
////    return <[|StringCom/**/ponentA|] />;
//// }

The issue first surfaced in 1.9.0-dev.20160212; indeed I think I've bisected the problem to 13167f5 using the above test

Activity

  1. Ryan Cavanaugh (RyanCavanaugh)
    self-assigned this
    on Feb 17, 2016
  2. Ryan Cavanaugh (RyanCavanaugh)
    added
    BugA bug in TypeScript
    on Feb 17, 2016
  3. Mohamed Hegazy (mhegazy)
    added this to the TypeScript 2.0 milestone on Feb 24, 2016

  4. myitcv commented on Feb 29, 2016

    @myitcv
    Paul Jolly (myitcv)
    on Feb 29, 2016
    Author

    Mohamed Hegazy (@mhegazy) Ryan Cavanaugh (@RyanCavanaugh) - anyone using tslint with the no-unused-variable rule (and React) is currently blocked from upgrading past 1.9.0-dev.20160212 (details palantir/tslint#972) because of this issue.

    Is there any chance therefore that this could be addressed before the 2.0 milestone?

    That would then allow us to pick up and test things like private constructors which landed in more recent nightlies.

    Thanks in advance

  5. RyanCavanaugh commented on Feb 29, 2016

    @RyanCavanaugh
    Ryan Cavanaugh (RyanCavanaugh)
    on Feb 29, 2016
    Member

    We'd take a PR at any time but I have other more urgent work at the moment. It'll probably be a week or two before I get to this.

  6. myitcv commented on Mar 2, 2016

    @myitcv
    Paul Jolly (myitcv)
    on Mar 2, 2016
    Author

    Thanks Ryan
    On 29 Feb 2016 21:29, "Ryan Cavanaugh" notifications@github.com wrote:

    We'd take a PR at any time but I have other more urgent work at the
    moment. It'll probably be a week or two before I get to this.

    —
    Reply to this email directly or view it on GitHub
    #7109 (comment)
    .

  7. myitcv commented on Mar 22, 2016

    @myitcv
    Paul Jolly (myitcv)
    on Mar 22, 2016
    Author

    Confirmed this is fixed by #7622 (thanks Mohamed Hegazy (@mhegazy)) available as of 1.9.0-dev.20160322

  8. Paul Jolly (myitcv)
    closed this as completedon Mar 22, 2016
  9. Mohamed Hegazy (mhegazy)
    added
    FixedA PR has been merged for this issue
    on Mar 22, 2016
  10. Daniel Rosenwasser (DanielRosenwasser)
    added
    Domain: JSX/TSXRelates to the JSX parser and emitter
    on Mar 22, 2016
  11. microsoft
    locked and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptDomain: JSX/TSXRelates to the JSX parser and emitterFixedA PR has been merged for this issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions