You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I dislike this, since @ts-ignore squelches all errors on the following line. If we remove one of these syntax kinds for some reason (or just introduce a typo), that use site will not be marked as an error after the removal (or typo introduction). I dislike the collateral damage this causes in terms of potential safety losses - this feels way too clunky.
This goes back to the problem of not being able to specify which specific error is ignored by // @ts-ignore; it's just a blanket ignore all things marker.
Is there no provision for, say, a // fallthrough or // fallsthrough comment in the lint rule? I believe at least the eslint rule that checks for this supports such comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have
// @ts-ignorecomments now, we don't need to use the lint rule for this any more.