Add 'fileToRename' property to RenameInfo

[Deleted user (ghost)]

Fixes #24501

Adds a fileToRename property to RenameInfo so that the editor can rename the file instead.

[Matt Bierner (mjbvz)]

Nice! I'll get initial support for this in VSCode this month so people using typescript@next can start testing

[Mohamed Hegazy (mhegazy)]

this could be a folder as well.. e.g.

// modules/a/index.ts

export var a;

import * from "./modules/a";

[Mohamed Hegazy (mhegazy)]

we should handle this case too.

And since we are renaming a module, we should also rename its references in tsconfig.json like "files"/"include"/"paths" etc..

I think we should just call in getEditsForFileRename instead of computing something on the fly.

[Ryan Cavanaugh (RyanCavanaugh)]

Andy (Andrewkraft) (@Andy-MS) please address conflicts + Mohamed's comments

[Deleted user (ghost)]

Matt Bierner (@mjbvz) Good to merge?

[Matt Bierner (mjbvz)]

Yes, we don't have support in VS Code for this yet but I'll add it this iteration

[Matt Bierner (mjbvz)]

Andy (Andrewkraft) (@Andy-MS) So is the expected behavior that when triggering rename on an import path in a file, we actually trigger the rename in the vscode file explorer?

[Deleted user (ghost)]

You could do that, which I'm guessing is the simplest way. Another option is to do the rename inline as usual, and change the name of the file without opening the file explorer.

[Matt Bierner (mjbvz)]

Ok, just so I make sure I understand what is supported:

1. Can you only rename the file itself or can you trigger a rename on directory in the path, such as renaming dir in import {} from './dir/file'

2. As part of the rename, should I ever be able to change the path, e.g. doing a rename from import {} from './file' to import {} from './sub/renamedFile'

[Deleted user (ghost)]

1. We trigger the rename on the entire string span, not on some part enclosed by /. (That could be changed if you want.) But if the import specifier is "./foo" and it imports from "./foo/index.ts", we'll try to rename the directory.
2. I think so.