Add separate PrivateIdentifier and SourceFile constructors by Swatinem · Pull Request #36844 · microsoft/TypeScript

Arpad Borsos (Swatinem) · 2020-02-17T22:53:02Z

This lowers the memory usage when compiling src/compiler
from 277M to 273M, so a modest ~1.5% win.

Same as #33431, this further splits Node from SourceFile, which reduces the size of Nodes from 160 bytes to 144

Nathan Shively-Sanders (sandersn) · 2020-02-26T23:37:13Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2020-02-26T23:37:15Z

Heya Nathan Shively-Sanders (@sandersn), I've started to run the perf test suite on this PR at 7228ef0. You can monitor the build here.

Update: The results are in!

Nathan Shively-Sanders (sandersn) · 2020-02-26T23:38:59Z

PrivateIdentifiers are rare and there are none in src/compiler, so I bet most of the gain is from SourceFile. Probably a project with lots of files would do even better than then compiler codebase.

TypeScript Bot (typescript-bot) · 2020-02-27T00:14:07Z

Nathan Shively-Sanders (@sandersn)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36844

Metric	master	36844	Delta	Best	Worst
Angular - node (v10.16.3, x64)
Memory used	333,999k (± 0.02%)	328,884k (± 0.02%)	-5,115k (- 1.53%)	328,722k	329,045k
Parse Time	1.62s (± 0.57%)	1.62s (± 0.75%)	-0.00s (- 0.12%)	1.58s	1.64s
Bind Time	0.89s (± 1.35%)	0.88s (± 0.34%)	-0.01s (- 0.56%)	0.88s	0.89s
Check Time	4.70s (± 0.58%)	4.71s (± 0.46%)	+0.01s (+ 0.26%)	4.68s	4.79s
Emit Time	5.24s (± 1.09%)	5.26s (± 0.66%)	+0.02s (+ 0.40%)	5.19s	5.33s
Total Time	12.45s (± 0.72%)	12.47s (± 0.41%)	+0.02s (+ 0.19%)	12.40s	12.64s
Monaco - node (v10.16.3, x64)
Memory used	335,204k (± 0.02%)	332,137k (± 0.01%)	-3,067k (- 0.92%)	332,024k	332,213k
Parse Time	1.25s (± 0.52%)	1.23s (± 0.66%)	-0.02s (- 1.52%)	1.22s	1.25s
Bind Time	0.77s (± 0.47%)	0.78s (± 0.63%)	+0.01s (+ 1.29%)	0.77s	0.79s
Check Time	4.70s (± 0.31%)	4.71s (± 0.49%)	+0.00s (+ 0.09%)	4.68s	4.77s
Emit Time	2.93s (± 0.97%)	2.91s (± 0.65%)	-0.03s (- 0.95%)	2.87s	2.97s
Total Time	9.66s (± 0.46%)	9.63s (± 0.19%)	-0.03s (- 0.30%)	9.60s	9.68s
TFS - node (v10.16.3, x64)
Memory used	299,386k (± 0.02%)	294,986k (± 0.01%)	-4,400k (- 1.47%)	294,905k	295,064k
Parse Time	0.94s (± 0.66%)	0.94s (± 0.39%)	-0.01s (- 0.53%)	0.93s	0.94s
Bind Time	0.74s (± 0.75%)	0.74s (± 0.45%)	-0.00s (- 0.27%)	0.73s	0.75s
Check Time	4.26s (± 0.31%)	4.24s (± 0.44%)	-0.02s (- 0.40%)	4.21s	4.29s
Emit Time	3.03s (± 0.38%)	3.02s (± 0.50%)	-0.01s (- 0.46%)	2.98s	3.05s
Total Time	8.97s (± 0.11%)	8.94s (± 0.20%)	-0.03s (- 0.36%)	8.90s	8.98s
Angular - node (v12.1.0, x64)
Memory used	309,651k (± 0.08%)	304,497k (± 0.08%)	-5,154k (- 1.66%)	303,562k	304,837k
Parse Time	1.57s (± 0.72%)	1.57s (± 0.67%)	+0.00s (+ 0.06%)	1.55s	1.59s
Bind Time	0.87s (± 0.79%)	0.86s (± 0.77%)	-0.00s (- 0.35%)	0.85s	0.88s
Check Time	4.59s (± 0.49%)	4.61s (± 0.38%)	+0.02s (+ 0.35%)	4.58s	4.65s
Emit Time	5.43s (± 1.15%)	5.43s (± 1.05%)	-0.01s (- 0.15%)	5.33s	5.55s
Total Time	12.46s (± 0.62%)	12.47s (± 0.54%)	+0.01s (+ 0.06%)	12.34s	12.62s
Monaco - node (v12.1.0, x64)
Memory used	315,078k (± 0.02%)	312,049k (± 0.01%)	-3,029k (- 0.96%)	311,978k	312,137k
Parse Time	1.20s (± 0.83%)	1.20s (± 0.58%)	-0.00s (- 0.08%)	1.18s	1.21s
Bind Time	0.74s (± 0.54%)	0.74s (± 0.87%)	+0.00s (+ 0.13%)	0.73s	0.76s
Check Time	4.55s (± 0.49%)	4.55s (± 0.47%)	-0.00s (- 0.00%)	4.50s	4.60s
Emit Time	2.94s (± 0.70%)	2.97s (± 0.78%)	+0.03s (+ 1.16%)	2.90s	3.00s
Total Time	9.43s (± 0.35%)	9.46s (± 0.35%)	+0.03s (+ 0.32%)	9.37s	9.53s
TFS - node (v12.1.0, x64)
Memory used	281,661k (± 0.02%)	277,333k (± 0.02%)	-4,328k (- 1.54%)	277,200k	277,425k
Parse Time	0.92s (± 0.84%)	0.91s (± 0.74%)	-0.01s (- 1.31%)	0.89s	0.92s
Bind Time	0.70s (± 1.14%)	0.71s (± 1.09%)	+0.01s (+ 1.28%)	0.70s	0.73s
Check Time	4.16s (± 0.42%)	4.17s (± 0.38%)	+0.00s (+ 0.07%)	4.13s	4.21s
Emit Time	3.03s (± 0.42%)	3.05s (± 0.47%)	+0.02s (+ 0.66%)	3.02s	3.08s
Total Time	8.82s (± 0.34%)	8.84s (± 0.22%)	+0.02s (+ 0.20%)	8.80s	8.90s
Angular - node (v8.9.0, x64)
Memory used	328,887k (± 0.01%)	323,875k (± 0.02%)	-5,011k (- 1.52%)	323,742k	324,018k
Parse Time	2.10s (± 0.39%)	2.09s (± 0.69%)	-0.01s (- 0.57%)	2.04s	2.12s
Bind Time	0.92s (± 0.83%)	0.93s (± 1.61%)	+0.01s (+ 1.64%)	0.91s	0.98s
Check Time	5.45s (± 0.46%)	5.50s (± 0.53%)	+0.05s (+ 0.92%)	5.45s	5.59s
Emit Time	6.19s (± 0.42%)	6.24s (± 0.48%)	+0.05s (+ 0.89%)	6.19s	6.32s
Total Time	14.66s (± 0.31%)	14.77s (± 0.35%)	+0.11s (+ 0.74%)	14.66s	14.89s
Monaco - node (v8.9.0, x64)
Memory used	333,477k (± 0.01%)	330,498k (± 0.02%)	-2,979k (- 0.89%)	330,360k	330,662k
Parse Time	1.53s (± 0.26%)	1.54s (± 0.63%)	+0.01s (+ 0.52%)	1.52s	1.56s
Bind Time	0.90s (± 1.82%)	0.83s (± 1.47%)	-0.07s (- 7.36%)	0.81s	0.86s
Check Time	5.33s (± 0.55%)	5.57s (± 0.51%)	+0.24s (+ 4.52%)	5.50s	5.65s
Emit Time	3.53s (± 0.49%)	3.56s (± 0.58%)	+0.03s (+ 0.96%)	3.52s	3.62s
Total Time	11.29s (± 0.23%)	11.51s (± 0.32%)	+0.22s (+ 1.94%)	11.42s	11.57s
TFS - node (v8.9.0, x64)
Memory used	298,770k (± 0.02%)	294,485k (± 0.02%)	-4,286k (- 1.43%)	294,381k	294,578k
Parse Time	1.25s (± 0.36%)	1.24s (± 0.27%)	-0.01s (- 0.72%)	1.24s	1.25s
Bind Time	0.75s (± 0.66%)	0.74s (± 0.80%)	-0.00s (- 0.27%)	0.73s	0.76s
Check Time	4.79s (± 0.50%)	4.79s (± 0.62%)	+0.00s (+ 0.02%)	4.72s	4.85s
Emit Time	3.37s (± 0.69%)	3.33s (± 1.84%)	-0.04s (- 1.30%)	3.09s	3.40s
Total Time	10.16s (± 0.36%)	10.11s (± 0.62%)	-0.05s (- 0.52%)	9.90s	10.22s
Angular - node (v8.9.0, x86)
Memory used	188,638k (± 0.02%)	186,074k (± 0.03%)	-2,564k (- 1.36%)	185,999k	186,197k
Parse Time	2.05s (± 0.70%)	2.03s (± 0.29%)	-0.02s (- 0.88%)	2.02s	2.05s
Bind Time	1.07s (± 0.52%)	1.07s (± 0.49%)	-0.00s (- 0.28%)	1.06s	1.08s
Check Time	5.00s (± 0.41%)	4.99s (± 0.70%)	-0.00s (- 0.10%)	4.93s	5.07s
Emit Time	6.14s (± 0.61%)	6.16s (± 0.63%)	+0.02s (+ 0.36%)	6.08s	6.26s
Total Time	14.26s (± 0.35%)	14.26s (± 0.50%)	-0.00s (- 0.01%)	14.13s	14.43s
Monaco - node (v8.9.0, x86)
Memory used	189,088k (± 0.02%)	187,626k (± 0.03%)	-1,462k (- 0.77%)	187,540k	187,801k
Parse Time	1.58s (± 0.89%)	1.59s (± 0.78%)	+0.01s (+ 0.44%)	1.56s	1.61s
Bind Time	0.77s (± 1.07%)	0.77s (± 0.72%)	+0.01s (+ 0.65%)	0.76s	0.78s
Check Time	5.36s (± 1.38%)	5.53s (± 0.48%)	+0.16s (+ 3.08%)	5.46s	5.58s
Emit Time	2.98s (± 3.37%)	2.88s (± 1.62%)	-0.10s (- 3.49%)	2.82s	3.04s
Total Time	10.69s (± 0.71%)	10.76s (± 0.44%)	+0.07s (+ 0.66%)	10.68s	10.87s
TFS - node (v8.9.0, x86)
Memory used	170,326k (± 0.03%)	168,183k (± 0.02%)	-2,142k (- 1.26%)	168,045k	168,225k
Parse Time	1.27s (± 0.59%)	1.28s (± 0.58%)	+0.01s (+ 0.47%)	1.27s	1.30s
Bind Time	0.72s (± 0.83%)	0.72s (± 1.54%)	+0.01s (+ 1.26%)	0.71s	0.76s
Check Time	4.60s (± 0.48%)	4.59s (± 0.35%)	-0.01s (- 0.24%)	4.55s	4.62s
Emit Time	2.95s (± 0.73%)	3.01s (± 2.01%)	+0.06s (+ 1.97%)	2.93s	3.21s
Total Time	9.54s (± 0.40%)	9.60s (± 0.63%)	+0.06s (+ 0.67%)	9.52s	9.79s

System

Machine Name	ts-ci-ubuntu
Platform	linux 4.4.0-166-generic
Architecture	x64
Available Memory	16 GB
Available Memory	1 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)

Benchmark	Name	Iterations
Current	36844	10
Baseline	master	10

Arpad Borsos (Swatinem) · 2020-02-27T08:30:11Z

so I bet most of the gain is from SourceFile.

Actually the gains are from Node not being mashed together with SourceFile anymore :-)

Nathan Shively-Sanders (sandersn) · 2020-02-27T17:19:25Z

I'd like Ron Buckton (@rbuckton) to sign off on this before merging. When I showed it to him yesterday, he pointed out that it's probably overkill to give all Nodes their own constructors, but the top 10 would benefit. Things like BinaryExpression, PropertyAccessExpression, maybe ElementAccessExpression. I'll let him give the entire list.

Arpad Borsos (Swatinem) · 2020-02-28T16:59:41Z

I also don’t think giving each node its own constructor is worth it. At least not now with the way that the API is structured.
What should give some more gains maybe is pre-defining all the properties that end up on some of the types. I don’t really know the compiler well enough to know which ones belong there.

Daniel Rosenwasser (DanielRosenwasser) · 2020-08-27T17:51:46Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2020-08-27T17:52:03Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 7228ef0. You can monitor the build here.

Daniel Rosenwasser (DanielRosenwasser) · 2020-08-27T17:52:48Z

I'll merge this in if the numbers look reasonable, otherwise there's no use in stalling this for generalizing it to other node types.

Arpad Borsos (Swatinem) · 2020-08-27T20:10:37Z

src/compiler/utilities.ts(5570,14): error TS2540: Cannot assign to 'pos' because it is a read-only property.

I think this needs a rebase at least.

Arpad Borsos (Swatinem) · 2020-08-27T21:25:08Z

Daniel Rosenwasser (@DanielRosenwasser) rebased, please try again

Daniel Rosenwasser (DanielRosenwasser) · 2020-08-27T21:51:26Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2020-08-27T21:51:30Z

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 458e665. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2020-08-27T22:29:00Z

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..36844

_Metric	_master	₃₆₈₄₄	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{344,439k (± 0.02%)}	_{344,471k (± 0.02%)}	_{+32k (+ 0.01%)}	_344,314k	_344,592k
_{Parse Time}	_{1.99s (± 0.80%)}	_{2.00s (± 0.55%)}	_{+0.01s (+ 0.60%)}	_1.99s	_2.03s
_{Bind Time}	_{0.82s (± 0.54%)}	_{0.82s (± 0.49%)}	_{-0.00s (- 0.12%)}	_0.81s	_0.83s
_{Check Time}	_{4.76s (± 0.27%)}	_{4.76s (± 0.31%)}	_{+0.01s (+ 0.13%)}	_4.73s	_4.80s
_{Emit Time}	_{5.18s (± 0.68%)}	_{5.19s (± 0.67%)}	_{+0.02s (+ 0.35%)}	_5.11s	_5.28s
_{Total Time}	_{12.75s (± 0.37%)}	_{12.78s (± 0.40%)}	_{+0.03s (+ 0.27%)}	_12.66s	_12.93s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{339,281k (± 0.03%)}	_{339,229k (± 0.04%)}	_{-52k (- 0.02%)}	_339,064k	_339,454k
_{Parse Time}	_{1.55s (± 0.47%)}	_{1.55s (± 0.78%)}	_{+0.01s (+ 0.39%)}	_1.53s	_1.59s
_{Bind Time}	_{0.71s (± 1.19%)}	_{0.71s (± 0.67%)}	_{+0.00s (+ 0.28%)}	_0.70s	_0.72s
_{Check Time}	_{4.95s (± 0.55%)}	_{4.96s (± 0.76%)}	_{+0.01s (+ 0.26%)}	_4.89s	_5.04s
_{Emit Time}	_{2.74s (± 0.82%)}	_{2.76s (± 0.94%)}	_{+0.02s (+ 0.80%)}	_2.72s	_2.84s
_{Total Time}	_{9.95s (± 0.45%)}	_{9.99s (± 0.50%)}	_{+0.04s (+ 0.44%)}	_9.89s	_10.14s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{302,243k (± 0.02%)}	_{302,280k (± 0.03%)}	_{+37k (+ 0.01%)}	_301,952k	_302,448k
_{Parse Time}	_{1.21s (± 0.78%)}	_{1.21s (± 0.73%)}	_{+0.01s (+ 0.58%)}	_1.20s	_1.24s
_{Bind Time}	_{0.68s (± 0.89%)}	_{0.67s (± 1.47%)}	_{-0.00s (- 0.44%)}	_0.64s	_0.69s
_{Check Time}	_{4.45s (± 0.44%)}	_{4.47s (± 0.43%)}	_{+0.02s (+ 0.43%)}	_4.42s	_4.50s
_{Emit Time}	_{2.90s (± 1.13%)}	_{2.88s (± 1.24%)}	_{-0.02s (- 0.55%)}	_2.81s	_2.97s
_{Total Time}	_{9.23s (± 0.46%)}	_{9.23s (± 0.43%)}	_{+0.00s (+ 0.04%)}	_9.16s	_9.36s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{460,811k (± 0.02%)}	_{460,837k (± 0.01%)}	_{+26k (+ 0.01%)}	_460,723k	_460,971k
_{Parse Time}	_{1.95s (± 0.49%)}	_{1.96s (± 0.74%)}	_{+0.01s (+ 0.72%)}	_1.93s	_2.00s
_{Bind Time}	_{0.66s (± 1.16%)}	_{0.66s (± 1.46%)}	_{-0.00s (- 0.00%)}	_0.64s	_0.68s
_{Check Time}	_{13.46s (± 1.13%)}	_{13.46s (± 0.55%)}	_{-0.00s (- 0.01%)}	_13.31s	_13.60s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.07s (± 0.94%)}	_{16.08s (± 0.49%)}	_{+0.01s (+ 0.06%)}	_15.90s	_16.21s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{321,730k (± 0.03%)}	_{321,637k (± 0.03%)}	_{-92k (- 0.03%)}	_321,418k	_321,772k
_{Parse Time}	_{1.99s (± 0.70%)}	_{1.99s (± 0.48%)}	_{+0.00s (+ 0.15%)}	_1.98s	_2.02s
_{Bind Time}	_{0.81s (± 1.11%)}	_{0.81s (± 0.58%)}	_{+0.01s (+ 0.62%)}	_0.80s	_0.82s
_{Check Time}	_{4.67s (± 0.65%)}	_{4.67s (± 0.48%)}	_{+0.00s (+ 0.09%)}	_4.64s	_4.73s
_{Emit Time}	_{5.34s (± 0.37%)}	_{5.40s (± 0.47%)}	_{+0.06s (+ 1.22%)}	_5.36s	_5.45s
_{Total Time}	_{12.80s (± 0.32%)}	_{12.88s (± 0.31%)}	_{+0.08s (+ 0.59%)}	_12.81s	_12.99s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{321,606k (± 0.01%)}	_{321,495k (± 0.02%)}	_{-111k (- 0.03%)}	_321,338k	_321,647k
_{Parse Time}	_{1.53s (± 0.65%)}	_{1.53s (± 0.80%)}	_{+0.00s (+ 0.07%)}	_1.50s	_1.56s
_{Bind Time}	_{0.69s (± 1.08%)}	_{0.69s (± 0.89%)}	_{-0.00s (- 0.29%)}	_0.68s	_0.70s
_{Check Time}	_{4.76s (± 0.57%)}	_{4.76s (± 0.81%)}	_{-0.00s (- 0.06%)}	_4.68s	_4.83s
_{Emit Time}	_{2.80s (± 0.49%)}	_{2.82s (± 0.53%)}	_{+0.02s (+ 0.82%)}	_2.78s	_2.85s
_{Total Time}	_{9.78s (± 0.45%)}	_{9.80s (± 0.47%)}	_{+0.02s (+ 0.19%)}	_9.70s	_9.88s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{286,588k (± 0.02%)}	_{286,569k (± 0.02%)}	_{-20k (- 0.01%)}	_286,430k	_286,678k
_{Parse Time}	_{1.22s (± 0.86%)}	_{1.22s (± 0.56%)}	_{+0.00s (+ 0.08%)}	_1.21s	_1.24s
_{Bind Time}	_{0.64s (± 0.77%)}	_{0.64s (± 0.81%)}	_{-0.00s (- 0.62%)}	_0.63s	_0.65s
_{Check Time}	_{4.36s (± 0.35%)}	_{4.36s (± 0.42%)}	_{-0.01s (- 0.16%)}	_4.32s	_4.40s
_{Emit Time}	_{2.93s (± 0.78%)}	_{2.96s (± 1.05%)}	_{+0.04s (+ 1.19%)}	_2.93s	_3.07s
_{Total Time}	_{9.16s (± 0.44%)}	_{9.19s (± 0.51%)}	_{+0.03s (+ 0.28%)}	_9.10s	_9.31s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{439,202k (± 0.05%)}	_{438,952k (± 0.07%)}	_{-250k (- 0.06%)}	_438,161k	_439,252k
_{Parse Time}	_{1.98s (± 0.83%)}	_{1.98s (± 0.81%)}	_{+0.00s (+ 0.05%)}	_1.94s	_2.01s
_{Bind Time}	_{0.63s (± 0.76%)}	_{0.63s (± 0.71%)}	_{+0.00s (+ 0.80%)}	_0.62s	_0.64s
_{Check Time}	_{12.04s (± 1.21%)}	_{12.11s (± 1.34%)}	_{+0.07s (+ 0.61%)}	_11.89s	_12.62s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.64s (± 1.06%)}	_{14.72s (± 1.08%)}	_{+0.08s (+ 0.55%)}	_14.47s	_15.21s
_{Angular - node (v8.9.0, x64)}
_{Memory used}	_{341,022k (± 0.02%)}	_{341,011k (± 0.01%)}	_{-11k (- 0.00%)}	_340,934k	_341,090k
_{Parse Time}	_{2.54s (± 0.49%)}	_{2.54s (± 0.54%)}	_{+0.00s (+ 0.04%)}	_2.51s	_2.57s
_{Bind Time}	_{0.85s (± 0.52%)}	_{0.86s (± 0.97%)}	_{+0.00s (+ 0.35%)}	_0.84s	_0.88s
_{Check Time}	_{5.41s (± 0.44%)}	_{5.43s (± 0.42%)}	_{+0.02s (+ 0.39%)}	_5.36s	_5.48s
_{Emit Time}	_{6.06s (± 1.60%)}	_{6.04s (± 1.78%)}	_{-0.02s (- 0.38%)}	_5.83s	_6.35s
_{Total Time}	_{14.86s (± 0.74%)}	_{14.86s (± 0.87%)}	_{-0.00s (- 0.00%)}	_14.66s	_15.24s
_{Monaco - node (v8.9.0, x64)}
_{Memory used}	_{340,628k (± 0.01%)}	_{340,500k (± 0.01%)}	_{-127k (- 0.04%)}	_340,398k	_340,619k
_{Parse Time}	_{1.88s (± 0.32%)}	_{1.87s (± 0.26%)}	_{-0.00s (- 0.11%)}	_1.86s	_1.88s
_{Bind Time}	_{0.89s (± 0.56%)}	_{0.89s (± 0.56%)}	_{-0.00s (- 0.11%)}	_0.87s	_0.89s
_{Check Time}	_{5.49s (± 0.44%)}	_{5.55s (± 0.95%)}	_{+0.06s (+ 1.02%)}	_5.46s	_5.70s
_{Emit Time}	_{3.23s (± 0.76%)}	_{3.21s (± 0.60%)}	_{-0.02s (- 0.50%)}	_3.18s	_3.28s
_{Total Time}	_{11.48s (± 0.38%)}	_{11.52s (± 0.46%)}	_{+0.03s (+ 0.30%)}	_11.42s	_11.65s
_{TFS - node (v8.9.0, x64)}
_{Memory used}	_{303,879k (± 0.02%)}	_{303,859k (± 0.01%)}	_{-20k (- 0.01%)}	_303,795k	_303,972k
_{Parse Time}	_{1.55s (± 0.37%)}	_{1.55s (± 0.48%)}	_{-0.00s (- 0.00%)}	_1.54s	_1.57s
_{Bind Time}	_{0.67s (± 0.99%)}	_{0.68s (± 0.59%)}	_{+0.01s (+ 0.89%)}	_0.67s	_0.69s
_{Check Time}	_{5.20s (± 0.51%)}	_{5.21s (± 0.46%)}	_{+0.01s (+ 0.27%)}	_5.15s	_5.27s
_{Emit Time}	_{2.93s (± 0.67%)}	_{2.94s (± 0.93%)}	_{+0.01s (+ 0.38%)}	_2.87s	_2.98s
_{Total Time}	_{10.35s (± 0.33%)}	_{10.38s (± 0.41%)}	_{+0.03s (+ 0.27%)}	_10.28s	_10.45s
_{material-ui - node (v8.9.0, x64)}
_{Memory used}	_{465,167k (± 0.01%)}	_{465,166k (± 0.01%)}	_{-1k (- 0.00%)}	_465,037k	_465,362k
_{Parse Time}	_{2.39s (± 0.55%)}	_{2.38s (± 0.52%)}	_{-0.01s (- 0.42%)}	_2.36s	_2.41s
_{Bind Time}	_{0.79s (± 1.28%)}	_{0.78s (± 1.07%)}	_{-0.01s (- 1.27%)}	_0.76s	_0.80s
_{Check Time}	_{18.05s (± 0.74%)}	_{18.06s (± 1.24%)}	_{+0.02s (+ 0.09%)}	_17.55s	_18.50s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{21.23s (± 0.66%)}	_{21.22s (± 1.11%)}	_{-0.00s (- 0.00%)}	_20.68s	_21.71s
_{Angular - node (v8.9.0, x86)}
_{Memory used}	_{195,717k (± 0.02%)}	_{195,612k (± 0.03%)}	_{-104k (- 0.05%)}	_195,528k	_195,777k
_{Parse Time}	_{2.45s (± 0.56%)}	_{2.46s (± 0.74%)}	_{+0.01s (+ 0.24%)}	_2.44s	_2.52s
_{Bind Time}	_{0.99s (± 0.40%)}	_{0.99s (± 0.73%)}	_{+0.00s (+ 0.30%)}	_0.98s	_1.01s
_{Check Time}	_{4.87s (± 0.33%)}	_{4.91s (± 0.67%)}	_{+0.04s (+ 0.84%)}	_4.83s	_5.00s
_{Emit Time}	_{5.92s (± 0.36%)}	_{5.99s (± 0.91%)}	_{+0.06s (+ 1.05%)}	_5.88s	_6.11s
_{Total Time}	_{14.24s (± 0.25%)}	_{14.35s (± 0.55%)}	_{+0.11s (+ 0.77%)}	_14.21s	_14.55s
_{Monaco - node (v8.9.0, x86)}
_{Memory used}	_{193,624k (± 0.01%)}	_{193,514k (± 0.02%)}	_{-110k (- 0.06%)}	_193,433k	_193,636k
_{Parse Time}	_{1.91s (± 0.91%)}	_{1.91s (± 1.29%)}	_{+0.01s (+ 0.42%)}	_1.88s	_1.98s
_{Bind Time}	_{0.70s (± 0.68%)}	_{0.70s (± 1.06%)}	_{0.00s ( 0.00%)}	_0.69s	_0.72s
_{Check Time}	_{5.54s (± 1.24%)}	_{5.63s (± 0.72%)}	_{+0.09s (+ 1.59%)}	_5.54s	_5.75s
_{Emit Time}	_{2.71s (± 3.21%)}	_{2.70s (± 1.04%)}	_{-0.01s (- 0.22%)}	_2.66s	_2.78s
_{Total Time}	_{10.85s (± 0.46%)}	_{10.94s (± 0.63%)}	_{+0.09s (+ 0.80%)}	_10.79s	_11.13s
_{TFS - node (v8.9.0, x86)}
_{Memory used}	_{173,833k (± 0.03%)}	_{173,830k (± 0.03%)}	_{-3k (- 0.00%)}	_173,748k	_173,969k
_{Parse Time}	_{1.59s (± 1.22%)}	_{1.58s (± 0.38%)}	_{-0.02s (- 0.94%)}	_1.57s	_1.59s
_{Bind Time}	_{0.64s (± 0.90%)}	_{0.65s (± 1.71%)}	_{+0.00s (+ 0.62%)}	_0.64s	_0.69s
_{Check Time}	_{4.72s (± 0.64%)}	_{4.72s (± 0.47%)}	_{-0.00s (- 0.06%)}	_4.67s	_4.76s
_{Emit Time}	_{2.80s (± 0.58%)}	_{2.81s (± 1.00%)}	_{+0.01s (+ 0.50%)}	_2.72s	_2.86s
_{Total Time}	_{9.75s (± 0.45%)}	_{9.76s (± 0.41%)}	_{+0.00s (+ 0.04%)}	_9.67s	_9.82s
_{material-ui - node (v8.9.0, x86)}
_{Memory used}	_{263,394k (± 0.01%)}	_{263,419k (± 0.02%)}	_{+25k (+ 0.01%)}	_263,326k	_263,544k
_{Parse Time}	_{2.44s (± 0.82%)}	_{2.45s (± 0.96%)}	_{+0.01s (+ 0.33%)}	_2.41s	_2.52s
_{Bind Time}	_{0.68s (± 1.79%)}	_{0.68s (± 1.28%)}	_{+0.00s (+ 0.44%)}	_0.66s	_0.69s
_{Check Time}	_{16.44s (± 0.97%)}	_{16.66s (± 0.81%)}	_{+0.21s (+ 1.31%)}	_16.36s	_16.98s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{19.56s (± 0.83%)}	_{19.79s (± 0.73%)}	_{+0.23s (+ 1.16%)}	_19.49s	_20.10s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-166-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{1 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v8.9.0, x64)
node (v8.9.0, x86)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v8.9.0, x64)
Angular - node (v8.9.0, x86)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v8.9.0, x64)
Monaco - node (v8.9.0, x86)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v8.9.0, x64)
TFS - node (v8.9.0, x86)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v8.9.0, x64)
material-ui - node (v8.9.0, x86)

_Benchmark	_Name	_Iterations
_Current	₃₆₈₄₄	₁₀
_Baseline	_master	₁₀

This lowers the memory usage when compiling `src/compiler` from **277M** to **273M**, so a modest ~1.5% win.

TypeScript Bot (typescript-bot) · 2022-03-18T01:16:02Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Ron Buckton (rbuckton) · 2022-03-18T01:16:24Z

TypeScript Bot (@typescript-bot) perf test

TypeScript Bot (typescript-bot) · 2022-03-18T01:16:27Z

Heya Ron Buckton (@rbuckton), I've started to run the perf test suite on this PR at 99b9eee. You can monitor the build here.

Update: The results are in!

TypeScript Bot (typescript-bot) · 2022-03-18T01:58:20Z

Ron Buckton (@rbuckton)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..36844

_Metric	_main	₃₆₈₄₄	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{356,332k (± 0.02%)}	_{356,378k (± 0.04%)}	_{+46k (+ 0.01%)}	_356,174k	_356,664k
_{Parse Time}	_{2.05s (± 0.46%)}	_{2.05s (± 0.52%)}	_{+0.00s (+ 0.05%)}	_2.03s	_2.08s
_{Bind Time}	_{0.87s (± 1.28%)}	_{0.86s (± 0.79%)}	_{-0.00s (- 0.12%)}	_0.85s	_0.88s
_{Check Time}	_{5.74s (± 0.22%)}	_{5.76s (± 0.57%)}	_{+0.02s (+ 0.31%)}	_5.70s	_5.85s
_{Emit Time}	_{5.98s (± 0.54%)}	_{6.02s (± 0.68%)}	_{+0.04s (+ 0.65%)}	_5.96s	_6.16s
_{Total Time}	_{14.64s (± 0.22%)}	_{14.70s (± 0.38%)}	_{+0.06s (+ 0.40%)}	_14.57s	_14.85s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{205,589k (± 0.02%)}	_{205,578k (± 0.02%)}	_{-11k (- 0.01%)}	_205,466k	_205,694k
_{Parse Time}	_{0.85s (± 0.56%)}	_{0.85s (± 0.61%)}	_{+0.00s (+ 0.24%)}	_0.84s	_0.86s
_{Bind Time}	_{0.52s (± 1.07%)}	_{0.51s (± 0.93%)}	_{-0.00s (- 0.97%)}	_0.50s	_0.52s
_{Check Time}	_{7.95s (± 0.74%)}	_{7.92s (± 0.44%)}	_{-0.03s (- 0.31%)}	_7.85s	_8.00s
_{Emit Time}	_{2.51s (± 0.44%)}	_{2.49s (± 0.50%)}	_{-0.03s (- 1.07%)}	_2.45s	_2.51s
_{Total Time}	_{11.82s (± 0.52%)}	_{11.77s (± 0.29%)}	_{-0.06s (- 0.48%)}	_11.68s	_11.85s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{343,639k (± 0.02%)}	_{343,525k (± 0.01%)}	_{-114k (- 0.03%)}	_343,458k	_343,640k
_{Parse Time}	_{1.57s (± 1.01%)}	_{1.57s (± 0.53%)}	_{+0.00s (+ 0.25%)}	_1.56s	_1.59s
_{Bind Time}	_{0.76s (± 0.73%)}	_{0.76s (± 0.99%)}	_{-0.00s (- 0.13%)}	_0.74s	_0.78s
_{Check Time}	_{5.70s (± 0.49%)}	_{5.70s (± 0.44%)}	_{+0.00s (+ 0.07%)}	_5.62s	_5.74s
_{Emit Time}	_{3.23s (± 0.34%)}	_{3.25s (± 0.51%)}	_{+0.02s (+ 0.77%)}	_3.22s	_3.28s
_{Total Time}	_{11.25s (± 0.37%)}	_{11.28s (± 0.31%)}	_{+0.03s (+ 0.28%)}	_11.20s	_11.35s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{305,318k (± 0.02%)}	_{305,254k (± 0.02%)}	_{-63k (- 0.02%)}	_305,146k	_305,396k
_{Parse Time}	_{1.28s (± 0.96%)}	_{1.28s (± 0.39%)}	_{-0.01s (- 0.47%)}	_1.27s	_1.29s
_{Bind Time}	_{0.72s (± 0.90%)}	_{0.71s (± 0.81%)}	_{-0.01s (- 0.70%)}	_0.70s	_0.72s
_{Check Time}	_{5.20s (± 0.29%)}	_{5.20s (± 0.50%)}	_{+0.00s (+ 0.06%)}	_5.16s	_5.28s
_{Emit Time}	_{3.43s (± 0.60%)}	_{3.46s (± 1.92%)}	_{+0.03s (+ 0.79%)}	_3.34s	_3.62s
_{Total Time}	_{10.63s (± 0.29%)}	_{10.65s (± 0.75%)}	_{+0.02s (+ 0.18%)}	_10.54s	_10.82s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{476,280k (± 0.01%)}	_{476,275k (± 0.01%)}	_{-5k (- 0.00%)}	_476,181k	_476,365k
_{Parse Time}	_{1.82s (± 0.53%)}	_{1.81s (± 0.49%)}	_{-0.00s (- 0.06%)}	_1.79s	_1.83s
_{Bind Time}	_{0.68s (± 0.91%)}	_{0.68s (± 0.66%)}	_{-0.00s (- 0.44%)}	_0.67s	_0.69s
_{Check Time}	_{22.80s (± 0.53%)}	_{22.85s (± 0.57%)}	_{+0.04s (+ 0.19%)}	_22.58s	_23.14s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{25.30s (± 0.47%)}	_{25.34s (± 0.52%)}	_{+0.04s (+ 0.15%)}	_25.06s	_25.66s
_{xstate - node (v10.16.3, x64)}
_{Memory used}	_{571,797k (± 0.01%)}	_{578,585k (± 1.73%)}	_{+6,788k (+ 1.19%)}	_571,667k	_605,660k
_{Parse Time}	_{2.57s (± 0.52%)}	_{2.57s (± 0.38%)}	_{0.00s ( 0.00%)}	_2.54s	_2.59s
_{Bind Time}	_{1.00s (± 0.36%)}	_{1.00s (± 0.55%)}	_{-0.00s (- 0.20%)}	_0.99s	_1.01s
_{Check Time}	_{1.50s (± 0.25%)}	_{1.51s (± 0.58%)}	_{+0.01s (+ 0.53%)}	_1.50s	_1.54s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.14s (± 0.29%)}	_{5.15s (± 0.35%)}	_{+0.01s (+ 0.21%)}	_5.11s	_5.19s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{334,152k (± 0.02%)}	_{334,106k (± 0.02%)}	_{-46k (- 0.01%)}	_333,914k	_334,184k
_{Parse Time}	_{2.04s (± 0.73%)}	_{2.04s (± 0.41%)}	_{-0.00s (- 0.10%)}	_2.02s	_2.06s
_{Bind Time}	_{0.83s (± 0.70%)}	_{0.82s (± 0.73%)}	_{-0.00s (- 0.24%)}	_0.81s	_0.84s
_{Check Time}	_{5.57s (± 0.55%)}	_{5.57s (± 0.44%)}	_{-0.00s (- 0.02%)}	_5.50s	_5.63s
_{Emit Time}	_{6.22s (± 0.60%)}	_{6.28s (± 0.72%)}	_{+0.06s (+ 0.88%)}	_6.21s	_6.40s
_{Total Time}	_{14.67s (± 0.53%)}	_{14.72s (± 0.42%)}	_{+0.05s (+ 0.37%)}	_14.60s	_14.90s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{193,034k (± 0.14%)}	_{193,093k (± 0.11%)}	_{+59k (+ 0.03%)}	_192,495k	_193,414k
_{Parse Time}	_{0.84s (± 0.77%)}	_{0.84s (± 0.66%)}	_{0.00s ( 0.00%)}	_0.83s	_0.85s
_{Bind Time}	_{0.53s (± 0.89%)}	_{0.53s (± 0.63%)}	_{0.00s ( 0.00%)}	_0.52s	_0.54s
_{Check Time}	_{7.37s (± 0.62%)}	_{7.41s (± 0.54%)}	_{+0.04s (+ 0.50%)}	_7.34s	_7.52s
_{Emit Time}	_{2.53s (± 1.13%)}	_{2.54s (± 0.94%)}	_{+0.01s (+ 0.32%)}	_2.49s	_2.58s
_{Total Time}	_{11.27s (± 0.60%)}	_{11.31s (± 0.45%)}	_{+0.04s (+ 0.40%)}	_11.24s	_11.47s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{326,544k (± 0.06%)}	_{326,545k (± 0.02%)}	_{+1k (+ 0.00%)}	_326,388k	_326,773k
_{Parse Time}	_{1.54s (± 0.50%)}	_{1.55s (± 0.79%)}	_{+0.01s (+ 0.71%)}	_1.52s	_1.57s
_{Bind Time}	_{0.75s (± 1.62%)}	_{0.74s (± 0.63%)}	_{-0.01s (- 0.67%)}	_0.73s	_0.75s
_{Check Time}	_{5.53s (± 0.49%)}	_{5.55s (± 0.50%)}	_{+0.02s (+ 0.33%)}	_5.49s	_5.63s
_{Emit Time}	_{3.24s (± 0.95%)}	_{3.29s (± 0.85%)}	_{+0.05s (+ 1.39%)}	_3.23s	_3.35s
_{Total Time}	_{11.06s (± 0.42%)}	_{11.13s (± 0.34%)}	_{+0.07s (+ 0.66%)}	_11.03s	_11.23s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{289,963k (± 0.01%)}	_{289,968k (± 0.02%)}	_{+5k (+ 0.00%)}	_289,867k	_290,086k
_{Parse Time}	_{1.30s (± 0.87%)}	_{1.29s (± 0.96%)}	_{-0.01s (- 0.46%)}	_1.27s	_1.32s
_{Bind Time}	_{0.70s (± 0.68%)}	_{0.71s (± 1.06%)}	_{+0.00s (+ 0.57%)}	_0.70s	_0.73s
_{Check Time}	_{5.14s (± 0.60%)}	_{5.11s (± 0.53%)}	_{-0.03s (- 0.55%)}	_5.06s	_5.19s
_{Emit Time}	_{3.48s (± 0.67%)}	_{3.52s (± 0.87%)}	_{+0.04s (+ 1.03%)}	_3.47s	_3.58s
_{Total Time}	_{10.62s (± 0.39%)}	_{10.62s (± 0.41%)}	_{+0.01s (+ 0.08%)}	_10.54s	_10.74s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{455,280k (± 0.03%)}	_{455,220k (± 0.09%)}	_{-60k (- 0.01%)}	_453,643k	_455,472k
_{Parse Time}	_{1.81s (± 0.59%)}	_{1.81s (± 0.71%)}	_{+0.01s (+ 0.39%)}	_1.79s	_1.85s
_{Bind Time}	_{0.64s (± 0.90%)}	_{0.64s (± 0.92%)}	_{+0.00s (+ 0.16%)}	_0.63s	_0.66s
_{Check Time}	_{20.33s (± 0.95%)}	_{20.22s (± 0.64%)}	_{-0.11s (- 0.55%)}	_20.07s	_20.55s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.78s (± 0.88%)}	_{22.68s (± 0.63%)}	_{-0.10s (- 0.44%)}	_22.50s	_23.06s
_{xstate - node (v12.1.0, x64)}
_{Memory used}	_{537,481k (± 0.02%)}	_{537,536k (± 0.02%)}	_{+55k (+ 0.01%)}	_537,423k	_537,722k
_{Parse Time}	_{2.51s (± 0.78%)}	_{2.52s (± 0.46%)}	_{+0.01s (+ 0.44%)}	_2.49s	_2.55s
_{Bind Time}	_{1.03s (± 0.85%)}	_{1.04s (± 0.45%)}	_{+0.01s (+ 0.97%)}	_1.03s	_1.05s
_{Check Time}	_{1.46s (± 0.65%)}	_{1.47s (± 0.51%)}	_{+0.01s (+ 0.41%)}	_1.46s	_1.49s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.07s (± 0.59%)}	_{5.10s (± 0.31%)}	_{+0.02s (+ 0.47%)}	_5.06s	_5.13s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{332,412k (± 0.01%)}	_{332,407k (± 0.01%)}	_{-4k (- 0.00%)}	_332,359k	_332,453k
_{Parse Time}	_{2.03s (± 0.46%)}	_{2.02s (± 0.52%)}	_{-0.01s (- 0.39%)}	_2.00s	_2.05s
_{Bind Time}	_{0.86s (± 0.58%)}	_{0.87s (± 0.39%)}	_{+0.00s (+ 0.23%)}	_0.86s	_0.87s
_{Check Time}	_{5.58s (± 0.34%)}	_{5.60s (± 0.41%)}	_{+0.02s (+ 0.29%)}	_5.56s	_5.65s
_{Emit Time}	_{6.28s (± 0.76%)}	_{6.37s (± 0.89%)}	_{+0.10s (+ 1.56%)}	_6.29s	_6.56s
_{Total Time}	_{14.74s (± 0.36%)}	_{14.86s (± 0.50%)}	_{+0.11s (+ 0.78%)}	_14.73s	_15.05s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{193,528k (± 0.62%)}	_{193,116k (± 0.65%)}	_{-411k (- 0.21%)}	_191,172k	_195,217k
_{Parse Time}	_{0.86s (± 0.78%)}	_{0.85s (± 0.43%)}	_{-0.00s (- 0.35%)}	_0.85s	_0.86s
_{Bind Time}	_{0.56s (± 0.71%)}	_{0.56s (± 0.72%)}	_{-0.00s (- 0.36%)}	_0.55s	_0.57s
_{Check Time}	_{7.46s (± 0.47%)}	_{7.44s (± 0.39%)}	_{-0.02s (- 0.24%)}	_7.38s	_7.50s
_{Emit Time}	_{2.48s (± 0.69%)}	_{2.51s (± 1.07%)}	_{+0.03s (+ 1.17%)}	_2.47s	_2.58s
_{Total Time}	_{11.36s (± 0.47%)}	_{11.37s (± 0.43%)}	_{+0.01s (+ 0.07%)}	_11.28s	_11.48s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{325,409k (± 0.01%)}	_{325,292k (± 0.01%)}	_{-118k (- 0.04%)}	_325,256k	_325,332k
_{Parse Time}	_{1.58s (± 0.87%)}	_{1.57s (± 0.53%)}	_{-0.00s (- 0.06%)}	_1.56s	_1.59s
_{Bind Time}	_{0.78s (± 1.67%)}	_{0.78s (± 0.79%)}	_{-0.00s (- 0.26%)}	_0.77s	_0.79s
_{Check Time}	_{5.46s (± 0.49%)}	_{5.49s (± 0.49%)}	_{+0.03s (+ 0.57%)}	_5.44s	_5.56s
_{Emit Time}	_{3.31s (± 0.66%)}	_{3.29s (± 0.54%)}	_{-0.02s (- 0.48%)}	_3.27s	_3.34s
_{Total Time}	_{11.13s (± 0.30%)}	_{11.14s (± 0.36%)}	_{+0.01s (+ 0.11%)}	_11.04s	_11.26s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{288,836k (± 0.01%)}	_{288,883k (± 0.01%)}	_{+47k (+ 0.02%)}	_288,813k	_288,927k
_{Parse Time}	_{1.31s (± 1.71%)}	_{1.32s (± 0.90%)}	_{+0.01s (+ 0.46%)}	_1.29s	_1.35s
_{Bind Time}	_{0.73s (± 0.91%)}	_{0.74s (± 0.49%)}	_{+0.00s (+ 0.41%)}	_0.73s	_0.74s
_{Check Time}	_{5.12s (± 0.42%)}	_{5.10s (± 0.53%)}	_{-0.01s (- 0.23%)}	_5.06s	_5.17s
_{Emit Time}	_{3.47s (± 2.00%)}	_{3.47s (± 1.62%)}	_{+0.00s (+ 0.06%)}	_3.38s	_3.57s
_{Total Time}	_{10.63s (± 0.78%)}	_{10.63s (± 0.59%)}	_{-0.01s (- 0.08%)}	_10.50s	_10.73s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{453,525k (± 0.06%)}	_{453,681k (± 0.03%)}	_{+156k (+ 0.03%)}	_453,074k	_453,796k
_{Parse Time}	_{1.85s (± 0.60%)}	_{1.85s (± 0.43%)}	_{-0.01s (- 0.27%)}	_1.83s	_1.87s
_{Bind Time}	_{0.71s (± 0.82%)}	_{0.70s (± 0.32%)}	_{-0.01s (- 1.13%)}	_0.69s	_0.70s
_{Check Time}	_{20.48s (± 0.76%)}	_{20.39s (± 0.83%)}	_{-0.09s (- 0.46%)}	_20.11s	_20.78s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{23.04s (± 0.69%)}	_{22.94s (± 0.76%)}	_{-0.10s (- 0.45%)}	_22.65s	_23.36s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{535,209k (± 0.01%)}	_{535,221k (± 0.00%)}	_{+12k (+ 0.00%)}	_535,156k	_535,269k
_{Parse Time}	_{2.56s (± 0.38%)}	_{2.56s (± 0.33%)}	_{+0.00s (+ 0.08%)}	_2.55s	_2.58s
_{Bind Time}	_{1.14s (± 0.81%)}	_{1.14s (± 0.77%)}	_{+0.00s (+ 0.09%)}	_1.12s	_1.16s
_{Check Time}	_{1.50s (± 0.63%)}	_{1.50s (± 0.47%)}	_{-0.00s (- 0.20%)}	_1.49s	_1.52s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.29s (± 0.31%)}	_{5.28s (± 0.24%)}	_{-0.00s (- 0.06%)}	_5.26s	_5.31s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{4 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v10.16.3, x64)
xstate - node (v12.1.0, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₃₆₈₄₄	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

Ron Buckton (rbuckton) · 2022-03-18T16:10:47Z

This doesn't seem to have a consistent positive effect on compilation as memory usage and compilation time are mostly unchanged. I don't think this change is warranted at this time.

Arpad Borsos (Swatinem) requested a review from Ron Buckton (rbuckton) February 17, 2020 22:53

Nathan Shively-Sanders (sandersn) added the For Backlog Bug PRs that fix a backlog bug label Feb 26, 2020

Nathan Shively-Sanders (sandersn) requested a review from Andrew Casey (amcasey) February 26, 2020 23:44

Nathan Shively-Sanders (sandersn) assigned Ron Buckton (rbuckton) Mar 9, 2020

Arpad Borsos (Swatinem) force-pushed the more-node-constructors branch from 7228ef0 to 458e665 Compare August 27, 2020 21:19

TypeScript Bot (typescript-bot) added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Backlog Bug PRs that fix a backlog bug labels Aug 27, 2020

Add separate PrivateIdentifier and SourceFile constructors

99b9eee

This lowers the memory usage when compiling `src/compiler` from **277M** to **273M**, so a modest ~1.5% win.

Ron Buckton (rbuckton) force-pushed the more-node-constructors branch from 458e665 to 99b9eee Compare March 18, 2022 01:15

Ron Buckton (rbuckton) closed this Mar 18, 2022

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025

Conversation

Arpad Borsos (Swatinem) commented Feb 17, 2020

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 26, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 26, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 27, 2020

Uh oh!

Arpad Borsos (Swatinem) commented Feb 27, 2020

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 27, 2020

Uh oh!

Arpad Borsos (Swatinem) commented Feb 28, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Aug 27, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Aug 27, 2020

Uh oh!

Arpad Borsos (Swatinem) commented Aug 27, 2020

Uh oh!

Arpad Borsos (Swatinem) commented Aug 27, 2020

Uh oh!

Daniel Rosenwasser (DanielRosenwasser) commented Aug 27, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 27, 2020

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 18, 2022

Uh oh!

Ron Buckton (rbuckton) commented Mar 18, 2022

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 18, 2022

Uh oh!

Ron Buckton (rbuckton) commented Mar 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TypeScript Bot (typescript-bot) commented Feb 26, 2020 •

edited

Loading

TypeScript Bot (typescript-bot) commented Aug 27, 2020 •

edited

Loading

TypeScript Bot (typescript-bot) commented Aug 27, 2020 •

edited

Loading

TypeScript Bot (typescript-bot) commented Mar 18, 2022 •

edited

Loading