Repository navigation
fix(46195): handle numeric separators and larger integers correctly in codefix for large integers - #46389
Merged
Conversation
Nathan Shively-Sanders (sandersn)
requested changes
Nov 17, 2021
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
The idea seems sound. I'd like to see a few more compiler tests.
LowR (lowr)
force-pushed
the
fix/46195
branch
from
November 19, 2021 11:01
562e0a6 to
8bd1d39
Compare
LowR (lowr)
force-pushed
the
fix/46195
branch
from
November 19, 2021 11:02
8bd1d39 to
fcc38fc
Compare
Nathan Shively-Sanders (sandersn)
approved these changes
Dec 3, 2021
Martin Probst (mprobst)
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
…n codefix for large integers (microsoft#46389) * fix(46195): handle numeric separators and larger integers correctly * Use `indexOf()` instead of `includes()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46195
This PR fixes 2 bugs, one of which I found while fixing the other:
node.text, which is not the textual representation of the literal in the source code, buttoString()representation of the number (explained here)node.textfor numeric literal1100000000000000000000is1.1e21, which has been bypassing the check due to the predicatenode.text.length <= 15.