Skip to content

[Experiment] feat(47558): Warning 6133 ignores @link tags - #47822

Merged
Nathan Shively-Sanders (sandersn) merged 1 commit into
microsoft:mainfrom
a-tarasyuk:feat/47558
Jun 6, 2022
Merged

[Experiment] feat(47558): Warning 6133 ignores @link tags#47822
Nathan Shively-Sanders (sandersn) merged 1 commit into
microsoft:mainfrom
a-tarasyuk:feat/47558

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

Fixes #47558

@typescript-bot TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Feb 9, 2022
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as draft February 19, 2022 18:49
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as ready for review February 20, 2022 06:58
sandersn
Nathan Shively-Sanders (sandersn) requested changes Feb 24, 2022
View reviewed changes
Comment thread src/compiler/checker.ts Outdated
sandersn
Nathan Shively-Sanders (sandersn) requested changes May 10, 2022
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does the right thing, but I'd like some tests to show that we don't start issuing errors on unresolved links.

Edit: Sorry this slipped through the cracks.

Comment thread tests/cases/conformance/jsdoc/jsdocLinkTag2.ts
Closed
5 tasks done
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Jun 6, 2022
View reviewed changes
Comment thread tests/cases/conformance/jsdoc/jsdocLinkTag5.ts
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 62668c6 into microsoft:main Jun 6, 2022
Closed
@Danielku15 Daniel Kuschny (Danielku15) mentioned this pull request Feb 15, 2025
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes

Assignees

@sandersn Nathan Shively-Sanders (sandersn)

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warning 6133 ignores @link tags

3 participants

@a-tarasyuk @sandersn @typescript-bot