Repository navigation
resolve from outDir - #48190
Closed
Alex Eagle (alexeagle) wants to merge 1 commit into
Closed
resolve from outDir#48190Alex Eagle (alexeagle) wants to merge 1 commit into
Alex Eagle (alexeagle) wants to merge 1 commit into
Conversation
Proof of concept for resolving microsoft#37378 Under the new proposed `compilerOptions.resolveFromOutDir` boolean, module resolution is attempted relative to the output folder. This is analogous to loading from the rootDirs, however it allows compilation where the output directory is configured on the command line rather than in the tsconfig.json. See the attached issue for context. TODO: - figure out what tests to add - reason about whether this interacts correctly with other related module resolution conditional logic - verify this works in some Bazel projects where the problem is observed
Greg Magolan (gregmagolan)
force-pushed
the
resolveFromOutDir
branch
from
March 10, 2022 23:38
e7e5c17 to
0afea27
Compare
Alex Eagle (alexeagle)
marked this pull request as ready for review
March 10, 2022 23:41
Ryan Cavanaugh (RyanCavanaugh)
requested a review
from Sheetal Nandi (sheetalkamat)
March 11, 2022 00:16
Greg Magolan (gregmagolan)
pushed a commit
to alexeagle/TypeScript
that referenced
this pull request
Mar 17, 2022
Sheetal Nandi (sheetalkamat)
requested changes
Mar 22, 2022
Sheetal Nandi (sheetalkamat)
left a comment
Member
There was a problem hiding this comment.
I think the suggestion was to compute outDir for the referenced project and not change module resolution.
Contributor
Author
|
Thanks Sheetal Nandi (@sheetalkamat) I replied on the associated issue about why this design was chosen. |
Nathan Shively-Sanders (sandersn)
requested a review
from Ryan Cavanaugh (RyanCavanaugh)
June 1, 2022 23:40
Member
|
Reading through the issue history, it looks like bazel doesn't need this PR anymore. I'm going to close it since I don't think Sheetal Nandi (@sheetalkamat) 's concerns ever changed. Alex Eagle (@alexeagle) let me know if we should re-open this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the new proposed
compilerOptions.resolveFromOutDirboolean,module resolution is attempted relative to the output folder.
This is analogous to loading from the rootDirs, however it allows
compilation where the output directory is configured on the command line
rather than in the tsconfig.json.
See the attached issue for context.
TODO:
module resolution conditional logic
Fixes #22208
Fixes #37378