Repository navigation
Use monocart for coverage reports, enable codecov - #58850
Merged
Merged
Conversation
Member
Author
|
I'm going to revert the CI and codecov change until we can get faster runners to not double our CI time. The local thing is fine, though, so I'll leave that working. I'll also do a benchmark quick to see how the report collection changes. |
Member
Author
|
The new runner pool is fast enough to give us coverage without slowing down CI. |
Jake Bailey (jakebailey)
marked this pull request as ready for review
June 19, 2024 22:11
Member
Author
|
Marked this PR as ready for review. Now that the CI perf is mitigated, should we just go ahead and enable codecov? |
Member
Author
|
Now just 2x slower. |
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental addition to
c8, but works really well.The v8 HTML page it outputs can load checker.ts without batting an eye, and has sub-expression fidelity and can see uncovered elses: