Skip to content

Preserve replacement lib order during sorting - #64693

Draft
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 3 commits into
mainfrom
copilot/replace-libs-load-order
Draft

Preserve replacement lib order during sorting#64693
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 3 commits into
mainfrom
copilot/replace-libs-load-order

Conversation

Copilot AI commented Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Problem: Replacement libs share a sort priority. Unstable sorting can reorder them, changing which merged-interface overload wins.
  • Change: Use stable sorting to preserve their configured order. Add a regression case covering fourteen replacement libs and overloads declared across adjacent files.

@typescript-automation typescript-automation Bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Oct 8, 2026
Copilot AI linked an issue Oct 8, 2026 that may be closed by this pull request
Replacement libs load in an arbitrary order in TypeScript 7: sortLibs is not stable #64687
Open
@typescript-automation typescript-automation Bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 8, 2026
Copilot AI and others added 2 commits October 8, 2026 16:32
@RyanCavanaugh
Add failing replacement lib order regression test
f83e823 
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
@RyanCavanaugh
Preserve ordering among equal-priority replacement libs
59c849a 
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix replacement libs load order in TypeScript 7 Preserve replacement lib order during sorting Oct 8, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh
Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh)

Copilot code review Copilot

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replacement libs load in an arbitrary order in TypeScript 7: sortLibs is not stable

2 participants

@RyanCavanaugh