Repository navigation
Optimize git status bucket classification - #38
Open
joshua-cyberclout wants to merge 1 commit into
Open
joshua-cyberclout wants to merge 1 commit into
joshua-cyberclout wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
joshua-cyberclout please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces per-file work in the Git status aggregation hot path by replacing repeated enum bucket scans with direct bitmask checks.
Why this helps
GitRepositoryStatus.Add was iterating through every FileStatus bucket for every file and calling HasFlag on each bucket. For larger repos, that multiplies the cost of status refreshes with little benefit because the underlying flags are already bit values.
This change preserves the same status buckets while removing repeated enum evaluation in the hot path.
Performance opportunities identified
Validation
Risk
Low: this is a hot-path optimization only; no user-facing status semantics are changed.