Repository navigation
[rush] Remove node tar fallback - #3653
Merged
David Michon (dmichon-msft) merged 1 commit intoSep 27, 2022
Merged
Conversation
David Michon (dmichon-msft)
force-pushed
the
node-tar-cleanup
branch
from
September 26, 2022 20:45
2b18633 to
5d62dc3
Compare
Ian Clanton-Thuon (iclanton)
approved these changes
Sep 26, 2022
David Michon (dmichon-msft)
enabled auto-merge
September 26, 2022 22:12
David Michon (dmichon-msft)
force-pushed
the
node-tar-cleanup
branch
from
September 27, 2022 00:28
b5024f6 to
05e8ce5
Compare
This was referenced Nov 28, 2023
This was referenced Mar 23, 2024
This was referenced May 13, 2024
This was referenced May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fallback to the node implementation of
tarin practice seems to only occur when the tarball is invalid, unless thetaris not onPATH. This results in restoring from corrupt cache entries and producing an invalid build result.This PR removes the fallback to node
tar.Fixes #3454
Fixes #2827
Details
Completely disables fallback path to node implementation of
tar. Updates logged warning to suggest ensuring thattaris onPATHor settingRUSH_TAR_EXECUTABLE_PATHto point totarin the event that the binary cannot be found.How it was tested
This is the normal state for most builds.