Repository navigation
[loader-load-themed-styles] Make @microsoft/load-themed-styles a peerDependency of @microsoft/loader-load-themed-styles. - #3656
Merged
Ian Clanton-Thuon (iclanton) merged 2 commits intoSep 28, 2022
Conversation
…der-load-themed-styles.
Ian Clanton-Thuon (iclanton)
requested review from
Daniel (D4N14L),
Apostolis Haitalis (apostolisms) and
Pete Gonzalez (octogonz)
as code owners
September 28, 2022 00:34
Ian Clanton-Thuon (iclanton)
enabled auto-merge
September 28, 2022 00:35
Ian Clanton-Thuon (iclanton)
requested a review
from Pat Miller (patmill)
as a code owner
September 28, 2022 00:45
Daniel (D4N14L)
approved these changes
Sep 28, 2022
Daniel (D4N14L)
left a comment
Contributor
There was a problem hiding this comment.
Just a note, the peer dep here won't be automatically updated when the version of the package gets bumped. That may be okay, just letting you know.
Member
Author
|
I intentionally made the peerdep version specifier broad. |
Ian Clanton-Thuon (iclanton)
disabled auto-merge
September 28, 2022 01:07
This was referenced Nov 28, 2023
This was referenced Mar 23, 2024
This was referenced May 13, 2024
This was referenced May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.