Repository navigation
Added ApiItemKind enum to ApiItem and refactored child classes - #79
Merged
Merged
Conversation
Pete Gonzalez (octogonz)
approved these changes
Feb 1, 2017
Pete Gonzalez (octogonz)
left a comment
Collaborator
There was a problem hiding this comment.
See notes
| export enum ApiItemKind { | ||
| /** | ||
| * A TypeScript class. | ||
| */ |
Collaborator
There was a problem hiding this comment.
Our coding convention is InitialCaps for enum members. This will also avoid any confusion with TypeScript language keywords such as "class"
| * A TypeScript class. | ||
| */ | ||
| class = 0, | ||
| /** |
Collaborator
There was a problem hiding this comment.
In your comment, it might also be useful to say which ApiItem class goes with each enum. E.g. Interface, Class, TypeLiteral are all ApiStructuredType
Pete Gonzalez (octogonz)
pushed a commit
that referenced
this pull request
Feb 13, 2017
Added ApiItemKind enum to ApiItem and refactored child classes
Christian Gonzalez (christiango)
pushed a commit
to christiango/web-build-tools
that referenced
this pull request
Aug 22, 2017
Added ApiItemKind enum to ApiItem and refactored child classes
This was referenced Nov 15, 2022
This was referenced Nov 28, 2022
This was referenced Dec 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApiItemKind enum is a refactoring needed for implementing local API reference resolution