Repository navigation
Misleading warning for progress callback exceptions #776
Description
Describe the bug
Currently a misleading warning is logged when a progress callback raises an exception.
It states that it "Failed to validate notification".
I've already issued a PR to fix it: #775
To Reproduce
async def progress_cb(progress: float, total: float | None, message: str | None):
raise RuntimeError("Cannot divide by zero.")
result = await self.session.call_tool(
tool_name,
arguments,
progress_callback=progress_cb,
)Expected behavior
Indicate to the developer that his callback threw an exception.
Activity
ivanbelenky commentedon May 22, 2025
I have no saying in anything but your PR looks good to me.
felixweinberger commentedon Oct 3, 2025
Closing this as #775 has been landed.