lookup: unskip aix and s390 for nan - #1150
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@giritrivedi looping you in on this pr |
abhayagarwal-dev
marked this pull request as ready for review
September 29, 2026 11:13
sxa
approved these changes
Sep 29, 2026
sxa
left a comment
Member
There was a problem hiding this comment.
Approving on the basis that this has been tested and I've seen the results.
Member
|
CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/294/
Other failures:
|
BethGriggs
approved these changes
Sep 29, 2026
BethGriggs
left a comment
Member
There was a problem hiding this comment.
Approving as CI now passes on AIX and s390x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unskip nan from AIX and S390x.
This was skipped because of endianess issue while decoding
UCS2 encodingon Big-Endian platformThe fix is merged with the upstream nan repository.
Issue: nan tests fail on three platforms with Node.js 20.x #996
Fix: fix(test): handle big-endian encoding in EncodeUCS2 test- #1023#1023
The smoke test is passing with the changes
Checklist
npm testpasseshere