Skip to content

lookup: unskip aix and s390 for nan - #1150

Merged
BethGriggs merged 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-s390
Sep 29, 2026
Merged

BethGriggs merged 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-s390

Conversation

@abhayagarwal-dev

Copy link
Copy Markdown
Contributor

This PR unskip nan from AIX and S390x.
This was skipped because of endianess issue while decoding UCS2 encoding on Big-Endian platform
The fix is merged with the upstream nan repository.
Issue: nan tests fail on three platforms with Node.js 20.x #996

Fix: fix(test): handle big-endian encoding in EncodeUCS2 test- #1023#1023

The smoke test is passing with the changes

info: starting            | nan                 
info: lookup              | nan                 
info: lookup-found        | nan                 
info: nan lookup-replace  | https://github.com/nodejs/nan/archive/HEAD.tar.gz
info: nan npm:            | Downloading project: https://github.com/nodejs/nan/archive/HEAD.tar.gz
info: nan npm:            | Project downloaded HEAD.tar.gz
info: nan npm:            | npm install started 
warn: nan npm-install:    | npm notice                                                             
warn:                     | npm notice New major version of npm available! 10.2.4 -> 12.1.0        
warn:                     | npm notice Changelog: <https://github.com/npm/cli/releases/tag/v12.1.0>
warn:                     | npm notice Run `npm install -g npm@12.1.0` to update!                  
warn:                     | npm notice                                                             
info: nan npm:            | npm install successfully completed
info: nan npm:            | test suite started  
info: passing module(s)   |                     
info: module name:        | nan                 
info: version:            | 2.29.0              
info: done                | The smoke test has passed.
info: duration            | test duration: 53547ms
Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter

codecov-commenter commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (126096c) to head (7d145a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abhayagarwal-dev

Copy link
Copy Markdown
Contributor Author

@giritrivedi looping you in on this pr

@giritrivedi giritrivedi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhayagarwal-dev
abhayagarwal-dev marked this pull request as ready for review September 29, 2026 11:13

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that this has been tested and I've seen the results.

@BethGriggs

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/294/

  • No failures on AIX and s390x

Other failures:

  • Windows is still failing on all versions
  • macOS issue on Node.js 26

@BethGriggs BethGriggs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as CI now passes on AIX and s390x

@BethGriggs
BethGriggs merged commit 93435a8 into nodejs:main Sep 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants