Repository navigation
fix(v8): concatenate adjacent strings in V8 DEPS files - #1212
Merged
Merged
Conversation
These follow Python string concatenation rules.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
=======================================
Coverage 63.12% 63.12%
=======================================
Files 65 65
Lines 12257 12257
=======================================
Hits 7737 7737
Misses 4520 4520 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Renegade334
reviewed
Oct 4, 2026
| const depsDeclaration = depsStr.substring(start, end) | ||
| .replace(/^ *#.*/gm, '') | ||
| // Join adjacent string literals | ||
| .replace(/'\s*\n\s*'/g, ''); |
Member
There was a problem hiding this comment.
Could this just be /'\s+'/g?
Member
Author
There was a problem hiding this comment.
I think yes, but the current one already works. Just merged it to unblock the workflow. Feel free to open a PR if you think that works better.
richardlau
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These follow Python string concatenation rules.