ci: use Visual Studio 2026 on windows-11-arm - #3380
Open
gengjiawen wants to merge 2 commits into
Open
gengjiawen wants to merge 2 commits into
gengjiawen wants to merge 2 commits into
Conversation
The windows-11-arm runner image moved to windows-11-vs2026-arm64, which
only ships Visual Studio 2026. Passing --msvs-version=2022 makes find VS
reject it ("msvs_version does not match this version"), so the
visual-studio (windows-11-arm, 2022) job has failed on every run since
2026-09-14.
3 tasks done
allVsVersions() stubbed findVisualStudio2017OrNewerUsingSetupModule, which no longer exists since nodejs#2959, so 18 tests spawned a real PowerShell to check for the VSSetup module. On windows-11-vs2026-arm64 under pwsh each spawn takes ~23s, pushing tests that make two of them past the 30s timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
visual-studio (windows-11-arm, 2022)has failed on every run since 2026-09-14 (18 in a row).The
windows-11-armlabel now resolves to thewindows-11-vs2026-arm64image (last passing run usedwindows-11-arm6420260906), which only ships Visual Studio 2026. With--msvs-version=2022, find VS rejects it:This switches the arm64 entry to
2026(same aswindows-2025) and drops the outdated "Fix this when Visual Studio 2025 is released" comment. Thevisual-studiorun on this PR is the verification.