test,flaky: test-cli-node-options

[refack]

• Version: 5f22375
• Platform: Windows
• Subsystem: test,cli

Consequent of #14195, for some reason

node.exe -e console.log("B")

fails sometimes
any ideas why would be appreciated.

not ok 54 parallel/test-cli-node-options
  ---
  duration_ms: 2.386
  severity: fail
  stack: |-
    assert.js:665
    assert.ifError = function ifError(err) { if (err) throw err; };
                                                      ^
    
    Error: Command failed: c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vs2017\label\win2016\Release\node.exe -e console.log("B")
    
        at ChildProcess.exithandler (child_process.js:268:12)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at maybeClose (internal/child_process.js:944:16)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:221:5)
  ...

https://ci.nodejs.org/job/node-test-binary-windows/10993/RUN_SUBSET=1,VS_VERSION=vs2017,label=win2016/console

[BridgeAR]

Here is a new stack trace:

not ok 59 parallel/test-cli-node-options
  ---
  duration_ms: 2.752
  severity: fail
  stack: |-
    assert.js:447
    assert.ifError = function ifError(err) { if (err) throw err; };
                                                      ^
    
    Error: Command failed: c:\workspace\node-test-binary-windows\Release\node.exe -e console.log("B")
    
    
    #
    # Fatal error in log.cc, line 253
    # Check failed: (perf_output_handle_) != nullptr.
    #
    
        at ChildProcess.exithandler (child_process.js:276:12)
        at ChildProcess.emit (events.js:131:13)
        at maybeClose (internal/child_process.js:943:16)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)

[richardlau]

@BridgeAR I think that one was from a CI run for #17600.

[BridgeAR]

@richardlau thanks, you are right. I did not check that after again after it came up as being flaky.

[Trott]

It seems like perhaps this should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.