Skip to content

test-os-process-priority failing on my Windows machine #22799

Closed
Closed
test-os-process-priority failing on my Windows machine#22799
Labels
testIssues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.

Description

@kfarnung
kfarnung
opened on Sep 10, 2018
  • Version: master
  • Platform: Windows
  • Subsystem: os

When I run the test suite I get the following failure:

=== release test-os-process-priority ===
Path: parallel/test-os-process-priority
assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected inputs to be strictly equal:

-14 !== -20

    at checkPriority (E:\GitHub\node\test\parallel\test-os-process-priority.js:120:12)
    at Object.<anonymous> (E:\GitHub\node\test\parallel\test-os-process-priority.js:97:3)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:270:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:801:3)
Command: E:\GitHub\node\Release\node.exe E:\GitHub\node\test\parallel\test-os-process-priority.js

I verified manually that setting the highest priority on my machine ends up setting high priority without any errors:

> const os = require('os')
undefined
> os.getPriority(0)
0
> os.setPriority(0, os.constants.priority.PRIORITY_HIGHEST)
undefined
> os.getPriority(0)
-14
> os.constants.priority.PRIORITY_HIGHEST
-20

It seems like although I'm asking for the highest priority Windows is pushing me down a level.

Activity

  1. kfarnung commented on Sep 10, 2018

    @kfarnung
    kfarnung
    on Sep 10, 2018
    ContributorAuthor

    Looks like this API was added by @cjihrig in #22407, is anyone else having issues with this test on Windows?

  2. kfarnung
    added a commit that references this issue on Sep 11, 2018

    test: mark `test-os-process-priority` flaky

    2b6f175

  3. refack commented on Sep 11, 2018

    @refack
    refack
    on Sep 11, 2018
    Contributor

    Two new contributors saw this in the last week.
    I can't repro, but my computer is in a weird UAC situation, so I'm guessing it might be an "Elevation" issue.

  4. kfarnung commented on Sep 11, 2018

    @kfarnung
    kfarnung
    on Sep 11, 2018
    ContributorAuthor

    That's my guess as well, the documentation doesn't call it out, but I suspect that the request for real-time priority is being downgraded transparently. I'm on Windows Insiders builds, so it's possible there's something with that as well.

  5. kfarnung
    added 3 commits that reference this issue on Sep 11, 2018

    test: mark `test-os-process-priority` flaky

    ffb8426

    test: mark `test-os-process-priority` flaky

    01464d4

    test: mark `test-os-process-priority` flaky

    9c2e4b2
  6. addaleax
    added
    windowsIssues and PRs related to the Windows platform.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Sep 11, 2018

  7. bzoz commented on Sep 12, 2018

    @bzoz
    bzoz
    on Sep 12, 2018
    Contributor

    The test fails for normal user and succeeds for elevated one.

  8. bzoz commented on Sep 12, 2018

    @bzoz
    bzoz
    on Sep 12, 2018
    Contributor

    Fix in #22817

  9. richardlau commented on Sep 12, 2018

    @richardlau
    richardlau
    on Sep 12, 2018
    Member

    Is this related to the SeIncreaseBasePriorityPrivilege user privilege?

  10. danbev
    closed this as completedin 6e746f1on Sep 19, 2018
  11. sjarmak
    added a commit that references this issue on Jul 27, 2026

    doc, win: improve os.setPriority documentation

    6e746f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions