Skip to content

build: missing defenitions from headers tarball #23167

Closed
#23426
Closed
build: missing defenitions from headers tarball#23167
#23426
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.opensslIssues and PRs related to the OpenSSL dependency.questionIssues asking questions about Node.js.v8 engineIssues and PRs related to the V8 dependency.zlibIssues and PRs related to the zlib module and its compression dependencies.

Description

@refack
refack
opened on Sep 29, 2018
  • Version:
  • Platform:
  • Subsystem:

I did a semi-thorough grep for symbols our deps use to customise their build, and found a few. First one might have helped find #23122 earlier.
Question is, should we define them, and how (probably via common.gypi)?

  • v8config.h
#if defined(V8_DEPRECATION_WARNINGS) && V8_HAS_ATTRIBUTE_DEPRECATED_MESSAGE
#if defined(V8_IMMINENT_DEPRECATION_WARNINGS) && \
  • zlib\zconf.h
#if defined(ZLIB_CONST) && !defined(z_const)
\include\node\openssl\zlib.h
#ifdef HAVE_UNISTD_H    /* may be set to #if 1 by ./configure */
#  define Z_HAVE_UNISTD_H
#endif
#ifdef HAVE_STDARG_H    /* may be set to #if 1 by ./configure */
#  define Z_HAVE_STDARG_H
#endif
  • openssl
# if defined(OPENSSL_NO_STDIO)
#if defined(OPENSSL_NO_ASM)
# if defined(OPENSSL_THREADS) && !defined(CRYPTO_TDEBUG)
# elif defined(OPENSSL_SYS_WINDOWS) && defined(OPENSSL_OPT_WINDLL)

@nodejs/build-files

Activity

  1. refack
    added
    questionIssues asking questions about Node.js.
    zlibIssues and PRs related to the zlib module and its compression dependencies.
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    v8 engineIssues and PRs related to the V8 dependency.
    opensslIssues and PRs related to the OpenSSL dependency.
    on Sep 29, 2018

  2. addaleax commented on Sep 30, 2018

    @addaleax
    addaleax
    on Sep 30, 2018
    Member

    The zlib symbols should all be taken care of – we have const available, HAVE_STDARG_H is not used for the features we need in core, and Z_HAVE_UNISTD_H is already set in deps/zlib/zlib.gyp.

    OPENSSL_NO_ASM is provided by our own configure script’s --openssl-no-asm.
    OPENSSL_THREADS sounds like something we don’t need because we already provide threadpool-based crypto functions.

  3. refack commented on Sep 30, 2018

    @refack
    refack
    on Sep 30, 2018
    ContributorAuthor

    The problem I see is that our configuration and gyp files are not necessarily propogated to the headers tarball.

  4. addaleax commented on Sep 30, 2018

    @addaleax
    addaleax
    on Sep 30, 2018
    Member

    The problem I see is that our configuration and gyp files are not necessarily propogated to the headers tarball.

    I’m not sure but I don’t think it’s an issue – the only thing that could potentially be defined is OPENSSL_NO_ASM, but that shouldn’t affect ABI/API, so it’s okay to have diverging definitions (and probably doesn’t have any impact at all on addons)?

  5. refack
    self-assigned this
    on Oct 4, 2018
  6. refack
    added a commit that references this issue on Nov 5, 2018

    build: add common `defines`

    765766b
  7. refack
    closed this as completedin #23426on Nov 5, 2018
  8. refack
    removed their assignment
    on Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.opensslIssues and PRs related to the OpenSSL dependency.questionIssues asking questions about Node.js.v8 engineIssues and PRs related to the V8 dependency.zlibIssues and PRs related to the zlib module and its compression dependencies.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions