tools: ICU shrinker needs to adapt to new output path #23245

Activity

1. srl295

   added

   i18n-apiIssues and PRs related to Node.js internationalization support.Issues and PRs related to Node.js internationalization support.

   on Oct 3, 2018
2. srl295

   self-assigned this

   on Oct 3, 2018
3. srl295 commented on Oct 3, 2018

   

   srl295

   on Oct 3, 2018

   MemberAuthor

   More actions

   also, #22450 moved configure to configure.py, so fix the docs also
4. srl295

   added

   docIssues and PRs related to Node.js documentation.Issues and PRs related to Node.js documentation.

   on Oct 3, 2018
5. refack commented on Oct 3, 2018

   

   refack

   on Oct 3, 2018

   Contributor

   More actions

   @srl295 Do the docs refer to this value:

   def configure_intl(o):
     icus = [
       {
         'url': 'https://sourceforge.net/projects/icu/files/ICU4C/62.1/icu4c-62_1-src.zip',
         'md5': '408854f7b9b58311b68fab4b4dfc80be',
       },
     ]

   I would actually believe is would be easy to read it from a file (say tools/icu/current_ver.dep)?

   👍React with 👍1Reacted by Steven R. Loomis
6. refack commented on Oct 4, 2018

   

   refack

   on Oct 4, 2018

   Last edited by refack

   Contributor

   More actions

   BTW @srl295 did you mean to post this and #23244 as PRs or issues?
7. srl295 commented on Oct 4, 2018

   

   srl295

   on Oct 4, 2018

   MemberAuthor

   More actions

   @refack issues. PR coming soon, but 63.1 is not final yet.

   👍React with 👍1Reacted by Refael Ackermann
8. srl295

   added a commit that references this issue on Oct 4, 2018

   tools: fix ICU shrinker and docs

   ...

   a4ffa0c
9. srl295

   closed this as completedin #23266on Oct 4, 2018
10. targos

    added a commit that references this issue on Oct 5, 2018

    tools: fix ICU shrinker and docs

    ...

    f2c90d0
11. targos

    added a commit that references this issue on Oct 7, 2018

    tools: fix ICU shrinker and docs

    ...

    1010ef5
12. refack

    added a commit that references this issue on Oct 12, 2018

    tools,icu: read full ICU version info from file

    ...

    be346d9
13. jasnell

    added 2 commits that reference this issue on Oct 17, 2018

    tools: fix ICU shrinker and docs

    ...

    b4da667

    tools,icu: read full ICU version info from file

    ...

    47af3a1
14. MylesBorins

    added a commit that references this issue on Oct 30, 2018

    tools,icu: read full ICU version info from file

    ...

    4344667
15. rvagg

    added a commit that references this issue on Nov 28, 2018

    tools,icu: read full ICU version info from file

    ...

    83bbd5e
16. MylesBorins

    added a commit that references this issue on Nov 29, 2018

    tools,icu: read full ICU version info from file

    ...

    cae703c