Skip to content

Allow 'data' argument on callback of Transform._flush() #3707

Description

@piranna

According to the docs, transform._transform(chunk, encoding, callback) callback accept optionals error and data chunk:

If you supply a second argument to the callback it will be passed to the push method

but the callback of transform._flush(callback) only accept an optional error. According to the code it would be fairly easy to add.

Activity

  1. piranna commented on Nov 7, 2015

    @piranna
    ContributorAuthor

    I've done a pull-request for this.

  2. added
    streamIssues and PRs related to Node.js streams.
    on Nov 8, 2015
  3. piranna commented on May 25, 2016

    @piranna
    ContributorAuthor

    Any update on this?

  4. piranna commented on Jun 9, 2016

    @piranna
    ContributorAuthor

    Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestIssues requesting new Node.js features.streamIssues and PRs related to Node.js streams.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions