Skip to content

Clarify where pull requests should go #407

Description

@RubenVerborgh

Given the large overlap of codebase between Node.js and io.js, it is often not easy for contributors to understand where to send patches. For instance, the two pull requests below express the exact same changes in the different projects:

What is the proper procedure?
Only create one pull request (where?) and hope it eventually gets merged in both?
Or create to pull requests like I have just done?

Maybe it would be good to clarify this in the contributors guidelines.

Activity

  1. mikeal commented on Jan 14, 2015

    @mikeal
    Contributor

    Send all patches here :)

  2. ryanseys commented on Jan 14, 2015

    @ryanseys
    Contributor

    I think this is up to the contributor. Of course @mikeal wants you to land it here! 😉

  3. RubenVerborgh commented on Jan 14, 2015

    @RubenVerborgh
    ContributorAuthor

    But what's best for the ecosystem? Submitting it to both then?

  4. bnoordhuis commented on Jan 14, 2015

    @bnoordhuis
    Member

    If it lands in joyent/node and it's noteworthy / useful enough, we'll eventually cherry-pick it into io.js. joyent/node is not known for high speed patch reviews, however; that's one of the reasons io.js exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions