readline documentation: event 'line' section wrongly restricts EOL to '\n' only

https://nodejs.org/api/readline.html#readline_event_line

Emitted whenever the input stream receives a \n, usually received when the user hits enter, or return.

I have tested this code with Windows 7 and Node 5.5.0 on three input files with Win-like EOL (\r\n), *nix-like EOL (\n) and old-Mac-like EOL (\r), and all the outputs were the same.

const fs = require('fs');
const readline = require('readline');

const rl = readline.createInterface({
  input: fs.createReadStream('test.txt', {encoding: 'utf8'}),
  terminal: false,
  historySize: 0
});

rl.on('line', line => {
  console.log(JSON.stringify(line));
});

It seems readline correctly parses files with all the main EOLs.

Looking at the code, it looks like it does check for all three cases. Care to make a docs PR?

Sorry, my English and Github skills are not that good.

doc: update eol handling in readline

Navigation Menu

Repository navigation

readline documentation: event 'line' section wrongly restricts EOL to '\n' only #4916

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

readline documentation: event 'line' section wrongly restricts EOL to '\n' only #4916

Description

Activity

cjihrig commented on Jan 28, 2016

vsemozhetbyt commented on Jan 28, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions