Skip to content

Zlib InflateRaw null reference #6034

Closed
Closed
Zlib InflateRaw null reference#6034
Labels
duplicateIssues and PRs that are duplicates of other issues or PRs.zlibIssues and PRs related to the zlib module and its compression dependencies.

Description

@headlessme
headlessme
opened on Apr 4, 2016
  • Version: v5.10.0 (also seen on 4.3.0)
  • Platform: Darwin Kernel Version 14.5.0
  • Subsystem: zlib

Zlib references a null object on close after an error:

var zlib = require('zlib');
var inflate = zlib.createInflateRaw(15);
inflate.on('error', function(e) {  });
inflate.write('something invalid');
setTimeout(function(){
    inflate.close();  
}, 100);

Output:

$ node inflate-close.js 
zlib.js:465
  this._handle.close();
              ^

TypeError: Cannot read property 'close' of null
    at InflateRaw.Zlib.close (zlib.js:465:15)
    at null._onTimeout (/tmp/inflate-close.js:8:13)
    at Timer.listOnTimeout (timers.js:92:15)

See websockets/ws#664

Activity

  1. headlessme commented on Apr 4, 2016

    @headlessme
    headlessme
    on Apr 4, 2016
    Author

    Looks like it's already being fixed: #5982

  2. headlessme
    closed this as completedon Apr 4, 2016
  3. ChALkeR
    added
    duplicateIssues and PRs that are duplicates of other issues or PRs.
    zlibIssues and PRs related to the zlib module and its compression dependencies.
    on Apr 4, 2016
  4. MylesBorins
    added 4 commits that reference this issue on Apr 20, 2016

    zlib: fix use after null when calling .close

    bad006f

    test: add zlib close-after-error regression test

    4bfed26

    zlib: fix use after null when calling .close

    4f6f599

    test: add zlib close-after-error regression test

    3bacd19

  5. 4 remaining items

  6. jasnell
    added 2 commits that reference this issue on Apr 26, 2016

    zlib: fix use after null when calling .close

    bd944e3

    test: add zlib close-after-error regression test

    6e3301f
  7. addaleax
    added a commit that references this issue on May 17, 2016

    zlib: remove `_closed` in source

    b53473f
  8. MylesBorins
    added 4 commits that reference this issue on May 17, 2016

    zlib: fix use after null when calling .close

    0cc1e0f

    test: add zlib close-after-error regression test

    4020451

    zlib: fix use after null when calling .close

    48684af

    test: add zlib close-after-error regression test

    f60ba54
  9. Fishrock123
    added a commit that references this issue on May 23, 2016

    zlib: remove `_closed` in source

    46003f0
  10. rvagg
    added a commit that references this issue on Jun 2, 2016

    zlib: remove `_closed` in source

    6441556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    duplicateIssues and PRs that are duplicates of other issues or PRs.zlibIssues and PRs related to the zlib module and its compression dependencies.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions