Skip to content

events: remove reaches into _events internals - #17440

Closed
apapirovski wants to merge 4 commits into
nodejs:masterfrom
apapirovski:patch-ee-internals-usage
Closed

apapirovski wants to merge 4 commits into
nodejs:masterfrom
apapirovski:patch-ee-internals-usage

Conversation

@apapirovski

@apapirovski apapirovski commented Dec 3, 2017 •

Copy link
Copy Markdown
Contributor

This strips out the harmless bits of #17324 into this standalone PR so they can actually land.

Refactoring of the lib & src code to eliminate all deep reaches into the internal _events dictionary object, instead use available APIs and add an extra method to EventEmitter: rawListeners (this seems to be a common reason to reach into _events in user-code as well).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

events

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. events Issues and PRs related to EventEmitter and the events module. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants