Skip to content

test: show child stderr output in largepages test - #31612

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:test-largepages-stderr
Closed

test: show child stderr output in largepages test#31612
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:test-largepages-stderr

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Feb 2, 2020

Copy link
Copy Markdown
Member

The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: #31547 (comment)

I propose fast-tracking this.

@bnoordhuis
bnoordhuis requested a review from addaleax February 2, 2020 01:51
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Feb 2, 2020
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28869/

Trott
Trott previously approved these changes Feb 2, 2020
View reviewed changes
@Trott Trott added fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Feb 2, 2020
@Trott

Trott commented Feb 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This causes the test to fail because it changes how stderr is handled so the assertion that checks stderr needs to be adjusted....

/home/iojs/build/workspace/node-test-commit-linux/nodes/debian9-64/test/parallel/test-startup-large-pages.js:25
  assert.strictEqual(child.stderr.toString().match(/\S+/g).slice(1).join(' '),
                                  ^

TypeError: Cannot read property 'toString' of null
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/debian9-64/test/parallel/test-startup-large-pages.js:25:35)
    at Module._compile (internal/modules/cjs/loader.js:1208:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1228:10)
    at Module.load (internal/modules/cjs/loader.js:1057:32)
    at Function.Module._load (internal/modules/cjs/loader.js:952:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47

@Trott
Trott dismissed their stale review February 2, 2020 02:36

pending test fix

@bnoordhuis
test: show child stderr output in largepages test
28f3ac0 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: nodejs#31547 (comment)
@bnoordhuis
bnoordhuis force-pushed the test-largepages-stderr branch from dee2e39 to 28f3ac0 Compare February 2, 2020 02:39
@bnoordhuis

bnoordhuis commented Feb 2, 2020

Copy link
Copy Markdown
Member Author

Oh pfft, that was the version I tried for reproducing the crash locally (no crash), not what I wanted to PR. Updated, PTAL.

@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28871/

@Trott

Trott commented Feb 2, 2020

Copy link
Copy Markdown
Member

Collaborators, 👍 here to approve fast-tracking.

@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Feb 2, 2020
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 2, 2020
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28873/

@addaleax

addaleax commented Feb 2, 2020

Copy link
Copy Markdown
Member

Landed in dbe881b

@addaleax addaleax closed this Feb 2, 2020
addaleax pushed a commit that referenced this pull request Feb 2, 2020
@bnoordhuis @addaleax
test: show child stderr output in largepages test
dbe881b 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: #31547 (comment)

PR-URL: #31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@bnoordhuis @codebytere
test: show child stderr output in largepages test
49be500 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: #31547 (comment)

PR-URL: #31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
@targos

targos commented Apr 18, 2020

Copy link
Copy Markdown
Member

depends on large pages change to land on v12.x

@targos targos removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-blocked-v12.x labels Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@bnoordhuis @targos
test: show child stderr output in largepages test
443610d 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: nodejs#31547 (comment)

PR-URL: nodejs#31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 28, 2020
@bnoordhuis @targos
test: show child stderr output in largepages test
4aaf407 
The test starts child processes. A recent change is suspected of causing
flaky crashes on one of the alpine buildbots but we can't know for sure
because the test hides the child's stderr.

Refs: #31547 (comment)

PR-URL: #31612
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request May 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bnoordhuis @nodejs-github-bot @Trott @addaleax @targos @cjihrig