src: rename misleading arg in ClientHelloParser - #44500
Merged
Merged
Conversation
Despite being named onend_arg, the pointer is passed both to the onend_cb and to the onhello_cb. Rename it to cb_arg, which matches the name of the class field cb_arg_.
Collaborator
|
Review requested:
|
commented
Sep 3, 2022
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Sep 3, 2022
This comment was marked as outdated.
This comment was marked as outdated.
commented
Sep 3, 2022
Collaborator
cjihrig
approved these changes
Sep 3, 2022
24 tasks
RaisinTen
approved these changes
Sep 4, 2022
commented
Sep 4, 2022
Collaborator
|
Landed in e43f0d7 |
17 tasks
17 tasks
15 tasks
This was referenced Sep 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite being named
onend_arg, the pointer is passed both to theonend_cband to theonhello_cb. Rename it tocb_arg, which matches the name of the class fieldcb_arg_.