doc: add return type to Blocklist.isBlocklist - #66181
Merged
nodejs-github-bot merged 1 commit intoSep 23, 2026
Merged
Conversation
Signed-off-by: Yuki Motokane <216834584+motokaneyuki@users.noreply.github.com>
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
lpinca
approved these changes
Sep 21, 2026
jasnell
approved these changes
Sep 21, 2026
pimterry
approved these changes
Sep 22, 2026
meixg
approved these changes
Sep 22, 2026
Collaborator
|
Landed in fd1f3e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds missing return type for
Blocklist.isBlocklist.According to what this function returns:
node/lib/internal/blocklist.js
Lines 79 to 81 in 2d32b18
Refs: nodejs/doc-kit#953