Skip to content

test: restrict default runs to OpenAI credentials - #5277

Merged
seratch merged 2 commits into
mainfrom
fix/openai-only-default-test-runs
Oct 2, 2026
Merged

seratch merged 2 commits into
mainfrom
fix/openai-only-default-test-runs

Conversation

@seratch

@seratch seratch commented Oct 2, 2026

Copy link
Copy Markdown
Member

This pull request updates default example and integration runs to retain OpenAI-backed and credential-free coverage while requiring explicit execution for additional-credential providers. It also fixes DeepWiki calls after the server renamed ask_question to ask_wiki_question.

  • Exclude 12 additional-credential examples from default auto runs, including the failing Runloop capabilities example. Preserve manual execution and custom skip-list overrides.
  • Require explicit external-provider flags or Make targets for integration coverage. Ignore inherited enable flags, remove known external provider keys from default child environments, and reject unsupported model overrides before builds.
  • Deselect unrequested external tests while preserving OpenAI adapter coverage and the strict release gate.
  • Update DeepWiki tool choices and allowlists in examples, integration tests, and integration guidance.

@seratch seratch added the project label Oct 2, 2026
@seratch
seratch requested review from a team and rm-openai as code owners October 2, 2026 02:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T05:14:36.625333Z 0a4b9f4 New commits
🔒 Security Review ✅ Completed 2026-10-02T05:13:47.021795Z 0a4b9f4 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0333905c6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread integration_tests/README.md
Require explicit opt-in for external integration providers and exclude
examples needing additional credentials from default auto runs.

Update hosted DeepWiki examples and integration tests to use the current
ask_wiki_question tool name.
@seratch
seratch force-pushed the fix/openai-only-default-test-runs branch from 0333905 to 0a4b9f4 Compare October 2, 2026 05:11

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete diff at 0a4b9f4. Default integration runs clear inherited provider-enable flags and external keys before bootstrap/build, while explicit provider flags retain the intended routes. Collection deselects only unrequested external cases; OpenAI adapter coverage, custom example skip lists and the strict release checks remain intact. No actionable correctness or structural findings.

Validation: inspected the new regression tests and the existing runner/provider paths; all 24 exact-head hosted checks passed, including Linux/Windows tests and packaged-contract checks. Source-only review: no local tests or live provider/DeepWiki calls were run.

Comment thread integration_tests/README.md
@seratch
seratch added this pull request to the merge queue Oct 2, 2026
Merged via the queue into main with commit a575a6e Oct 2, 2026
28 checks passed
@seratch
seratch deleted the fix/openai-only-default-test-runs branch October 2, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants