Is it worthwhile to separate Diffable and Writeable? #8

Activity

1. mvdan commented on Jul 9, 2018

   

   mvdan

   on Jul 9, 2018

   ContributorAuthor

   More actions

   Here's another proposal - make Writeable half of what it is. That is:

   type Writeable interface {
       WriteTo(w io.Writer, i int) (int, error)
       Filename() string
   }
   
   func (e EditScript) WriteUnified(w io.Writer, left, right Writeable) (int, error)
   

   Then the issue is that helpers like Strings would either start returning a Diffable only, or Diffable, Writeable, Writeable.

   Still, this option B would remove the need for DiffWriteable, and it would make funcs like WriteUnified a bit more modular.
2. josharian commented on Aug 28, 2019

   

   josharian

   on Aug 28, 2019

   Contributor

   More actions

   Here's another proposal - make Writeable half of what it is.

   This interacts with #4, which would get rid of the Filename part of Writeable. At which point it is a single method, so it could be a func param. I can't say that this feels like it fixes any problems, though.

   Another option would be give Diffable an AtA and AtB method to get individual elements, and then just pass whatever those return into fmt.Fprint. This has an appeal, but it doesn't play nicely with diffing and writing slices of byte slices, since by default, byte slices print as a slice of integral values. We could work around that by special-casing byte slices, but that's ugly.

   Any other ideas?
3. josharian

   added a commit that references this issue on Aug 30, 2019

   rework writing API

   ...

   060157d
4. josharian commented on Aug 30, 2019

   

   josharian

   on Aug 30, 2019

   Contributor

   More actions

   I just pushed some commits that make this a bit cleaner. I still agree it'd be nice to do something cleaner here; writing is a bit of a fly in the ointment. So I'll leave this open a bit for further discussion. But I'm out of ideas at the moment.
5. josharian

   added

   needs thoughtunclear what the right path forward isunclear what the right path forward is

   on Aug 30, 2019