Fix extraction of nested named expressions - #876
Open
yangfan-yf-yf wants to merge 2 commits into
Open
yangfan-yf-yf wants to merge 2 commits into
yangfan-yf-yf wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 134 134
Lines 26819 26819
=======================================
Hits 25570 25570
Misses 1249 1249 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracting
i := a == (c := 5)can generateif i, c := new_func(a):, which is invalid Python. I fixed the named-expression visitor to traverse the assigned value so the existing extraction check detects the nested assignment and raisesRefactoringError.I updated the regression test that previously expected the invalid output. Single named-expression extraction and extraction of complete statements remain supported by the existing tests.
Fixes #871
Validation
python -m pytest -q— 2116 passed, 12 skipped, 5 xfailed.RefactoringError not raised).The first full run had two autoimport failures because my temporary directory was under an underscore-prefixed path. I reproduced both on unmodified master and reran the full suite successfully with a different temporary directory.
Checklist