Skip to content

tok_report_warnings in tokenizer state is not needed #106989

Closed
Closed
tok_report_warnings in tokenizer state is not needed#106989
Labels
3.13only security fixeseasyinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Description

@lysnikolaou
lysnikolaou
opened on Jul 22, 2023

When we merged PEP 701, we added tok_report_warnings, which apparently got in by accident. The issue it was trying to solve was already resolved in #99891 and #99893. I think that it can safely removed both from the tokenizer struct and all occurences should be changed to use report_warnings instead.

Linked PRs

Activity

  1. lysnikolaou
    added
    type-bugAn unexpected behavior, bug, or error
    easy
    3.13only security fixes
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Jul 22, 2023

  2. menkotoglou commented on Jul 22, 2023

    @menkotoglou
    menkotoglou
    on Jul 22, 2023
    Contributor

    I can work on this, during the EuroPython 2023 sprints.

  3. pablogsal
    added a commit that references this issue on Jul 22, 2023

    gh-106989: Remove tok report warnings (#106993)

    76e20c3
  4. miss-islington
    added a commit that references this issue on Jul 22, 2023

    pythongh-106989: Remove tok report warnings (pythonGH-106993)

    d72e981
  5. pablogsal
    closed this as completedon Jul 22, 2023
  6. pablogsal
    added a commit that references this issue on Jul 22, 2023

    [3.12] gh-106989: Remove tok report warnings (GH-106993) (#107013)

    b6ace75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixeseasyinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions