Repository navigation
_Py_c_sum, _Py_c_diff, etc - were removed from Python.h #112019
Description
Activity
CC @vstinner
If these functions are useful, I would prefer to make them public.
Previous discussion about this private API: #106320 (comment)
@skirpichev: Do you use these functions? Do you know a project using these functions? A code search on PyPI top 5,000 projects only found 1 line using
_Py_c_pow()in the numba project.@mdickinson, should we expose these functions and details of the Py_complex struct, what do you think?
If these functions are useful, I would prefer to make them public.
Code search shows they aren't used too much.
@skirpichev: Do you use these functions?
Not outside of CPython itself.
PS: (I'm moving discussion from #106320)
The C99 complex API is documented at: https://en.cppreference.com/w/c/numeric/complex
It seems, see e.g. (https://discuss.python.org/t/33433/23, llvm/llvm-project#8904), that none of popular compilers (icc maybe an exception) support this extension correctly.
@mdickinson, should we expose these functions and details of the Py_complex struct, what do you think?
Members of the
Py_complexstructure are public since the structure was added to Python 1.4 by commit f9fca92 in 1996. The structure was calledcomplexand then was renamed toPy_complex.The
Py_complexfunctions are already documented but have a_Pyprefix.Also they take struct by value, a bit strange API.
Later, we should consider deprecating these functions and make them fully internal.
Maybe we could keep this issue for that?
Maybe we could keep this issue for that?
I prefer to wait until a migration path is decision on how to get rid of private functions (which were reverted in Python 3.13. alpha2): capi-workgroup/api-evolution#24
See #106339 and #106320. But these functions are documented as public: https://docs.python.org/3/c-api/complex.html#complex-numbers-as-c-structures
I think c38c666 should be partially reverted and
_Py_c_abs- documented.On another hand, quick github search shows very little examples of using above functions. See also #106320 (comment). So, in a long term I propose to deprecate this API and related functions (PyComplex_FromCComplex/PyComplex_AsCComplex). Who knows, maybe someday we could use
<complex.h>...Linked PRs