Skip to content

Invalid datetime.time.fromisoformat #124257

Closed
#105856
Closed
Invalid datetime.time.fromisoformat#124257
#105856
Labels
stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

@random1st
random1st
opened on Sep 19, 2024

Bug report

Bug description:

According to the standard ISO 8601 Thus the value ‘24:00:00’ is chosen to represent the final instant of the day in order to distinguish the expression of this instant from an expression of a time scale unit.

>>> datetime.time.fromisoformat("24:00")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: hour must be in 0..23

Link to standard pdf

CPython versions tested on:

3.10, 3.12

Operating systems tested on:

Linux, macOS

Activity

  1. random1st
    added
    type-bugAn unexpected behavior, bug, or error
    on Sep 19, 2024
  2. Eclips4
    added
    stdlibStandard Library Python modules in the Lib/ directory
    on Sep 19, 2024
  3. Eclips4
    added this to Date and time issues 🕰️on Sep 19, 2024

  4. eendebakpt commented on Sep 19, 2024

    @eendebakpt
    eendebakpt
    on Sep 19, 2024
    Contributor

    Some other discussions on supporting this: dotnet/runtime#12197, astropy/astropy#9837

    Also note the documentation of datetime.datetime.fromisoformat:

    Return a date corresponding to a date_string given in any valid ISO 8601 format, with the following

    The part "in any valid ISO 8601" suggest that fromisodate should support 24:00

  5. tomasr8 commented on Sep 19, 2024

    @tomasr8
    tomasr8
    on Sep 19, 2024
    Member

    The part "in any valid ISO 8601" suggest that fromisodate should support 24:00

    On one hand it says any valid ISO 8601 format (which with the latest amendement to the spec 24:00 is). On the other hand, it also lists exceptions to the spec. Even though I think it would make sense to support 24:00, if it's decided against it, I think we should at least document this discrepancy in the docs

  6. hugovk commented on Sep 19, 2024

    @hugovk
    hugovk
    on Sep 19, 2024
    Member

    Is this a duplicate of #102450 (or #54636)?

  7. eendebakpt commented on Sep 19, 2024

    @eendebakpt
    eendebakpt
    on Sep 19, 2024
    Contributor

    There is an open PR to allow 24:00: #105856. I can review it (but it would be nice to know beforehand whether we actually want to allow 24:00).

    @pganssle @abalkin as code owners

  8. pganssle
    closed this as completedin #105856on Sep 25, 2024
  9. github-project-automation
    moved this to Done in Date and time issues 🕰️on Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions