Moving _PyMem_RawStrdup to private API causes build failure

#106320 causes build failure in marcelotduarte/cx_Freeze#2568 (comment)

What is the recommended replacement for the now private function?

Made private here: #107187

I think as a replacement you can do what the function is doing internally, that is, call PyMem_RawMalloc and memcpy:

cpython/Objects/obmalloc.c

Lines 1047 to 1057 in 52d552c

    
           _PyMem_RawStrdup(const char *str) 
        
           { 
        
               assert(str != NULL); 
        
               size_t size = strlen(str) + 1; 
        
               char *copy = PyMem_RawMalloc(size); 
        
               if (copy == NULL) { 
        
                   return NULL; 
        
               } 
        
               memcpy(copy, str, size); 
        
               return copy; 
        
           }

@vstinner

@vstinner Do you think it's worth adding a public variation of PyMem_Strdup and PyMem_RawStrdup?

@ZeroIntensity

@ZeroIntensity:

@vstinner Do you think it's worth adding a public variation of PyMem_Strdup and PyMem_RawStrdup?

It's not worth it. Please don't add them.

There is a simple replacement for _PyMem_RawStrdup(): just use strdup() (with free()). If you really need/want to use PyMem_RawMalloc(), you can copy/paste the code that @tomasr8 gave.

Replace _PyMem_RawStrdup with strdup

@clin1234

@clin1234: Would you be ok to close the issue? Or do you think that something else should be done? I'm not sure why you closed your cx_Freeze upstream PR.

I made a separate pull request replacing the private function with strdup (marcelotduarte/cx_Freeze#2738)

Navigation Menu

Repository navigation

Moving `_PyMem_RawStrdup` to private API causes build failure #127991

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	_PyMem_RawStrdup(const char *str)
	{
	assert(str != NULL);
	size_t size = strlen(str) + 1;
	char *copy = PyMem_RawMalloc(size);
	if (copy == NULL) {
	return NULL;
	}
	memcpy(copy, str, size);
	return copy;
	}

Moving _PyMem_RawStrdup to private API causes build failure #127991

Description

Activity

tomasr8 commented on Dec 16, 2024

ZeroIntensity commented on Dec 16, 2024

vstinner commented on Dec 17, 2024

vstinner commented on Dec 17, 2024

clin1234 commented on Dec 17, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Moving `_PyMem_RawStrdup` to private API causes build failure #127991