Skip to content

NOT_TAKEN instructions need to be added after optimization #128533

Closed
Closed
NOT_TAKEN instructions need to be added after optimization#128533
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

Description

@markshannon
markshannon
opened on Jan 6, 2025

The NOT_TAKEN instruction is added during code gen, but can be left when jumps are removed by the optimizer.

We should probably add the NOT_TAKEN instructions in the assembler after optimization, as suggested in #122564 (comment)

Linked PRs

Activity

  1. picnixz
    added
    type-featureA feature request or enhancement
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Jan 6, 2025
  2. markshannon
    changed the title [-]`NOT_TAKEN` instructions need to added after optimization[/-] [+]`NOT_TAKEN` instructions need to be added after optimization[/+] on Jan 6, 2025
  3. markshannon
    added a commit that references this issue on Jan 6, 2025

    GH-128533: Add `NOT_TAKEN` instruction after bytecode optimization. (G…

    2434fd2
  4. markshannon
    closed this as completedon Jan 7, 2025
  5. srinivasreddy
    added a commit that references this issue on Jan 8, 2025

    pythonGH-128533: Add `NOT_TAKEN` instruction after bytecode optimizat…

    c48285e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions